Support environment markers during pex activation. #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had support for environment markers on the resolve side for a while and with just a little plumbing we can now support multi-python pexes with environment-specific requirements. Fixes pex-tool#456
CMLivingston
approved these changes
Oct 8, 2018
Eric-Arellano
approved these changes
Oct 8, 2018
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Oct 8, 2018
)" This reverts commit 5f1f00f. We want to do a 1.4.9 bugfix release before this ~API change.
jsirois
added a commit
that referenced
this pull request
Oct 8, 2018
This reverts commit 5f1f00f. We want to do a 1.4.9 bugfix release before this ~API change.
jsirois
added a commit
that referenced
this pull request
Oct 9, 2018
Laevos
pushed a commit
to Laevos/pex
that referenced
this pull request
Oct 9, 2018
# The first commit's message is: pex-tool#572: Allow import of ctypes to be skipped if use_manylinux is false # This is the 2nd commit message: Narrow the env marker test. (pex-tool#578) The jupyter dist is just a meta-dist with fully unconstrained deps on ~6 other dists. This test was added to test environment marker support in pex, which ipython - not jupyter - leverages heavily. # This is the 3rd commit message: Fix resolve regressions introduced by the 1.4.8. (pex-tool#580) PR pex-tool#571 regressed the half-broken state of having `--interpreter_constraint` selected interpreters not setup to also having `--python` selected interpreters also not setup. In addition, PR pex-tool#568 incorrectly classified the current Platform passed by `resolve_multi` as a user-specified extended platform specification breaking custom interpreter resolution. Fix both and add tests that failed prior to this combination of fixes. A more comprehensive fix is tracked in part by pex-tool#579. # This is the 4th commit message: Cleanup `PexInfo` and `PythonInterpreter`. (pex-tool#581) Kill an unused type in `PexInfo` as well as our last remaining use of `pkg_resources.get_platform`. Also kill unused `COMPATIBLE_SETUPTOOLS` constants in `PythonInterpreter`. # This is the 5th commit message: Support environment markers during pex activation. (pex-tool#582) We've had support for environment markers on the resolve side for a while and with just a little plumbing we can now support multi-python pexes with environment-specific requirements. Fixes pex-tool#456 # This is the 6th commit message: Revert "Support environment markers during pex activation. (pex-tool#582)" This reverts commit 5f1f00f. We want to do a 1.4.9 bugfix release before this ~API change. # This is the 7th commit message: Prepare the 1.4.9 release. (pex-tool#588) Work towards pex-tool#583 # This is the 8th commit message: Revert "Revert "Support environment markers during pex activation. (pex-tool#582)"" This reverts commit 44ff463. This restores pex-tool#582 for the 1.5.0 release tracked by pex-tool#585.
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Nov 3, 2018
In pex-tool#582 and pex-tool#592 support for environment markers was added to the pex runtime. In so doing, the resolver was fixed to record full requirement strings into PEX-INFO. Since part of those full requirement strings could now include environment markers that selected for active extras, a bug was introduced since we did not also add the active extras to the environment marker evaluation environment. This change adds a failing test that is fixed by properly setting up the environment marker environment to include active extras. Fixes pex-tool#615.
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Nov 3, 2018
In pex-tool#582 and pex-tool#592 support for environment markers was added to the pex runtime. In so doing, the resolver was fixed to record full requirement strings into PEX-INFO. Since part of those full requirement strings could now include environment markers that selected for active extras, a bug was introduced since we did not also add the active extras to the environment marker evaluation environment. This change adds a failing test that is fixed by properly setting up the environment marker environment to include active extras. Fixes pex-tool#615.
jsirois
added a commit
that referenced
this pull request
Nov 4, 2018
In #582 and #592 support for environment markers was added to the pex runtime. In so doing, the resolver was fixed to record full requirement strings into PEX-INFO. Since part of those full requirement strings could now include environment markers that selected for active extras, a bug was introduced since we did not also add the active extras to the environment marker evaluation environment. This change adds a failing test that is fixed by properly setting up the environment marker environment to include active extras. Fixes #615.
jsirois
added a commit
to jsirois/pex
that referenced
this pull request
Jun 24, 2019
The change in pex-tool#582 introduced a bug where requested extras were not preserved for local `setup.py` resolvables. Add failing tests for this and fix. Fixes pex-tool#736
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had support for environment markers on the resolve side for a
while and with just a little plumbing we can now support multi-python
pexes with environment-specific requirements.
Fixes #456