-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resolution of setup.py
project extras.
#739
Conversation
The change in pex-tool#582 introduced a bug where requested extras were not preserved for local `setup.py` resolvables. Add failing tests for this and fix. Fixes pex-tool#736
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this and adding tests!
My comments take inspiration from the idea of Atoms of Confusion, that confusing small snippets result in the majority of a project's bugs. Everything looks good now, but the confusing parts down the road may cause issues.
PROJECT_CONTENT = { | ||
'setup.py': dedent(''' | ||
@contextlib.contextmanager | ||
def make_project(name='my_project', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good refactor to generalize this 👌
+ Define and check ResolvedDistribution field types. + Restore explicit parameters to pex.testing.make_sdist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
The change in #582 introduced a bug where requested extras were not
preserved for local
setup.py
resolvables. Add failing tests for thisand fix.
Fixes #736