Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolution of setup.py project extras. #739

Merged
merged 2 commits into from
Jun 25, 2019

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Jun 24, 2019

The change in #582 introduced a bug where requested extras were not
preserved for local setup.py resolvables. Add failing tests for this
and fix.

Fixes #736

The change in pex-tool#582 introduced a bug where requested extras were not
preserved for local `setup.py` resolvables. Add failing tests for this
and fix.

Fixes pex-tool#736
@jsirois jsirois requested a review from Eric-Arellano June 24, 2019 14:21
pex/testing.py Show resolved Hide resolved
@jsirois jsirois mentioned this pull request Jun 24, 2019
6 tasks
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this and adding tests!

My comments take inspiration from the idea of Atoms of Confusion, that confusing small snippets result in the majority of a project's bugs. Everything looks good now, but the confusing parts down the road may cause issues.

pex/resolver.py Show resolved Hide resolved
pex/testing.py Show resolved Hide resolved
pex/testing.py Outdated Show resolved Hide resolved
PROJECT_CONTENT = {
'setup.py': dedent('''
@contextlib.contextmanager
def make_project(name='my_project',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactor to generalize this 👌

+ Define and check ResolvedDistribution field types.
+ Restore explicit parameters to pex.testing.make_sdist.
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@jsirois jsirois merged commit bb4d83b into pex-tool:master Jun 25, 2019
@jsirois jsirois deleted the issues/736 branch June 25, 2019 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies specified in extra_requires don't work from 1.5.0 onwards
2 participants