-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pex 1.5.1 bombs with unhandled pkg_resources._vendor.packaging.markers.UndefinedEnvironmentName
on certain resolves
#615
Comments
noting the shape of the markers in the failure case is (from the apache-beam wheel):
|
OK - thanks for the report. Easy repro and the fix appears to be tiny. |
The bug is not on the resolution side, but in the activation side where we filter out embedded dists not appropriate to the current enviornment the pex is running in. |
In pex-tool#582 and pex-tool#592 support for environment markers was added to the pex runtime. In so doing, the resolver was fixed to record full requirement strings into PEX-INFO. Since part of those full requirement strings could now include environment markers that selected for active extras, a bug was introduced since we did not also add the active extras to the environment marker evaluation environment. This change adds a failing test that is fixed by properly setting up the environment marker environment to include active extras. Fixes pex-tool#615.
In pex-tool#582 and pex-tool#592 support for environment markers was added to the pex runtime. In so doing, the resolver was fixed to record full requirement strings into PEX-INFO. Since part of those full requirement strings could now include environment markers that selected for active extras, a bug was introduced since we did not also add the active extras to the environment marker evaluation environment. This change adds a failing test that is fixed by properly setting up the environment marker environment to include active extras. Fixes pex-tool#615.
In #582 and #592 support for environment markers was added to the pex runtime. In so doing, the resolver was fixed to record full requirement strings into PEX-INFO. Since part of those full requirement strings could now include environment markers that selected for active extras, a bug was introduced since we did not also add the active extras to the environment marker evaluation environment. This change adds a failing test that is fixed by properly setting up the environment marker environment to include active extras. Fixes #615.
I'm going to re-open this one since the current workaround fix just pushes a new bug downstream and the fix in #613 will handle both these issues. |
Opps - wrong re-open. |
repro:
vs 1.4.4:
The text was updated successfully, but these errors were encountered: