Include xml:lang attribute in ServiceName and ServiceDescription
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SAML2 metadata documentation states that these fields are of the `localizedNameType` type. This means that an `xml:lang` attribute that indicates which language the text is written in, is required. This change adds this attribute, with a value of `en` (just like for md:OrganizationName etc.) Fixes perl-net-saml2#223
waterkip
approved these changes
May 21, 2024
| @@ -66,8 +66,8 @@ sub to_xml { | |||
| index => $self->index, | |||
| isDefault => $self->default, | |||
| }, | |||
| $xml->ServiceName($self->namespace, undef, $self->service_name), | |||
| $self->_has_service_description ? $xml->ServiceDescription($self->namespace, undef, $self->service_description) : (), | |||
| $xml->ServiceName($self->namespace, { 'xml:lang' => 'en' }, $self->service_name), | |||
There was a problem hiding this comment.
Perhaps instead of hardcoding it to 'en' we can add it as an attribute (and default it to 'en'), so others can define their own language, eg, 'it', 'nl' etc?
@timlegge wdyt?
I could also accept this and change it in another commit.
There was a problem hiding this comment.
Yeah I think we do need a way to specify a language but as @MartijnVdS pointed out it is hard coded in the generate_metadata so lets approve her and add an issue to fix everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SAML2 metadata documentation states that these fields are of the
localizedNameTypetype. This means that anxml:langattribute that indicates which language the text is written in, is required.This change adds this attribute, with a value of
en(just like for md:OrganizationName etc.)Fixes #223