Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required attribute xml:lang is missing from SP metadata, in md:ServiceName and md:ServiceDescription under md:AttributeConsumingService #223

Closed
MartijnVdS opened this issue May 21, 2024 · 0 comments · Fixed by #224
Closed

Required attribute xml:lang is missing from SP metadata, in md:ServiceName and md:ServiceDescription under md:AttributeConsumingService #223

MartijnVdS opened this issue May 21, 2024 · 0 comments · Fixed by #224

Comments

@MartijnVdS
Copy link

In the specification that defines SAML metadata (https://docs.oasis-open.org/security/saml/v2.0/saml-metadata-2.0-os.pdf), in section 2.4.4.1, the md:ServiceName and md:ServiceDescription elements are defined as having type md:localizedNameType.

md:localizedNameType is defined as an extension of string, with a required xml:lang attribute.

Currently, the SAML SP metadata generated by Net::SAML2, does not include include the xml:lang attribute for the ServiceName and ServiceDescription elements, like it does for md:Organization/md:OrganizationName and md:Organization/md:OrganizationDisplayName.
@MartijnVdS MartijnVdS changed the title xml:lang attribute is required in ServiceName and ServiceDescription in AttributeConsumingService Required attribute xml:lang is missing from SP metadata, in md:ServiceName and md:ServiceDescription under md:AttributeConsumingService May 21, 2024
MartijnVdS pushed a commit to MartijnVdS/perl-Net-SAML2 that referenced this issue May 21, 2024
Include xml:lang attribute in ServiceName and ServiceDescription
aefae65 
The SAML2 metadata documentation states that these fields are of the
`localizedNameType` type. This means that an `xml:lang` attribute
that indicates which language the text is written in, is required.

This change adds this attribute, with a value of `en` (just like for
md:OrganizationName etc.)

Fixes perl-net-saml2#223
@MartijnVdS MartijnVdS mentioned this issue May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include xml:lang attribute in ServiceName and ServiceDescription MartijnVdS/perl-Net-SAML2
1 participant
@MartijnVdS