Merge pull request #224 from MartijnVdS/xmllang

Include `xml:lang` attribute in ServiceName and ServiceDescription
perl-net-saml2 · May 21, 2024 · 0fc0914 · 0fc0914
2 parents 9e84760 + aefae65
commit 0fc0914
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/lib/Net/SAML2/AttributeConsumingService.pm b/lib/Net/SAML2/AttributeConsumingService.pm
@@ -66,8 +66,8 @@ sub to_xml {
             index     => $self->index,
             isDefault => $self->default ? 'true' : 'false',
         },
-        $xml->ServiceName($self->namespace, undef, $self->service_name),
-        $self->_has_service_description ? $xml->ServiceDescription($self->namespace, undef, $self->service_description) : (),
+        $xml->ServiceName($self->namespace, { 'xml:lang' => 'en' }, $self->service_name),
+        $self->_has_service_description ? $xml->ServiceDescription($self->namespace, { 'xml:lang' => 'en' }, $self->service_description) : (),
         map { $_->to_xml } @{ $self->attributes },
     );
 }

diff --git a/t/02-create-sp.t b/t/02-create-sp.t
@@ -480,6 +480,8 @@ use URN::OASIS::SAML2 qw(:bindings :urn);
         'Net::SAML2 testsuite',
         ".. with the correct value"
     );
+    is($child[0]->getAttribute("xml:lang"),
+        "en", ".. and xml:lang is set");
 
     is($child[1]->nodeName, "md:RequestedAttribute",
         "Requested attribute found");

diff --git a/t/28-attribute-consuming-service.t b/t/28-attribute-consuming-service.t
@@ -24,6 +24,11 @@ is(
     "Net::SAML2 testsuite",
     ".. and has the correct content"
 );
+is(
+    $node->getAttribute('xml:lang'),
+    "en",
+    ".. and has the correct xml:lang"
+);
 
 $node = get_single_node_ok($xpath,
     '/md:AttributeConsumingService/md:RequestedAttribute');