-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Pub enum runtime to pub struct runtime #13250
Pub enum runtime to pub struct runtime #13250
Conversation
This would be a breaking change for all downstream projects… |
This should be non-breaking and work out of the box afaik.
So yeah, I think its worth. @a-moreira please run and please add your Polkadot / Kusama address to your PR description per https://github.com/paritytech/substrate-tip-bot |
This should not be breaking as Shawn said. Just use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm down to mark the usage of pub enum whatever
as deprecated as well, and then remove it.
If so others agree, please do that in this PR as well.
What's the reason for doing this? |
We are at the academy, and it is just more clear to use a |
bot rebase |
Error: Command 'Command { std: "git" "push" "--porcelain" "a-moreira" "pub-enum-runtime-to-pub-struct-runtime", kill_on_drop: false }' failed with status Some(1); output: error: failed to push some refs to 'https://x-access-token:${SECRET}@github.com/a-moreira/substrate.git' |
CI needs work @a-moreira |
@kianenigma sorry for the delay, I was AFK in the last days. Fixing now |
@kianenigma CI works. I updated |
bot merge |
Waiting for commit status. |
Merge cancelled due to error. Error: Statuses failed for 2daecc0 |
bot rebase |
…-pub-struct-runtime
Rebased |
bot fmt |
@bkchr https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2493661 was started for your command Comment |
@bkchr Command |
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-40/2468/1 |
* pub enum Runtime -> pub struct Runtime * changing some more * fmt * updating *.stderr files * re-run trybuild after rust update * keep a test file for `pub enum Runtime` * Delete construct_runtime_2.rs * ".git/.scripts/commands/fmt/fmt.sh" --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: parity-processbot <>
* pub enum Runtime -> pub struct Runtime * changing some more * fmt * updating *.stderr files * re-run trybuild after rust update * keep a test file for `pub enum Runtime` * Delete construct_runtime_2.rs * ".git/.scripts/commands/fmt/fmt.sh" --------- Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: parity-processbot <>
This PR simply substitutes
Pub enum Runtime
forPub struct Runtime
in theconstruct_runtime!
macros, as suggested by @kianenigma on the Polkadot Blockchain Academy this week :-)polkadot address: 14WCnNFaTCYW2BTS2rDMHacvWdfQEPp2kJjAsp9VdHJJrNNT