-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Substrate #1347
Update Substrate #1347
Conversation
a1b6df0
to
ee652de
Compare
…834c7fb` (and ORML vesting to `0085382cf001704d084ac8e97b7bc3e4e8afb8a7`) and apply minimal-ish changes to make things compile and pass tests
ee652de
to
5663a09
Compare
ORML docs didn't pass tests |
@liuchengxu @NingLin-P test failed with:
https://github.com/subspace/subspace/actions/runs/4591054185/jobs/8106976976?pr=1347 Works for me locally though, must be performance sensitive? |
Works for me locally as well. It looks more like an interesting glitch somewhere, with some debugging in CI, I found that the ack of slot notification somehow never resolves, https://github.com/subspace/subspace/blob/0043ed4726/test/subspace-test-service/src/mock.rs#L182-L184, still working on it. |
I had no local issues with tests. |
Update dependencies, remove now unnecessary override for `chacha20poly1305`
CI in #1348 (built on top of this) passed for some reason. Let's see if it happens again and if so we can merge it. |
Pulled in paritytech/substrate#13804 |
Worked for me locally as well for eth relay domain. |
Should I ignore it for now so we can make progress here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I think it is totally OK to skip the failing tests and let the Execution team handle it. If you can create an issue, would be great.
@nazar-pc Let's ignore the failing test for now. I reproduced it locally with a busy machine but haven't got a clue. @NingLin-P It can be reproduced with busy CPUs. For example, run |
Thanks for the clue! I will look into it. |
Now Though judging by #1345 (comment) it just gets stuck and increasing timeout will not help. |
ba669f5
to
e358993
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The chain sync changes appear to be mostly code moved around, I will resync autonomys/substrate#46 after this is merged
Upstream changes I found relevant/important/interesting:
Weight::from_{ref_time, proof_size}
paritytech/substrate#13475sc-network
paritytech/substrate#12828Currency
; introduce holds and freezing intofungible
traits paritytech/substrate#12951With this release LLVM version shouldn't matter anymore on macOS or other platforms.
A lot of moving parts have changed because of above PRs, I had to re-apply our Substrate tweaks on top of upstream and created https://github.com/subspace/substrate/tree/subspace-v4 branch for that. Changes were caused by networking refactoring, but after applying tweaks one by one it compiled and should work fine (I'm successfully syncing with this branch onto Gemini 3d).
Follow-ups required for:
Code contributor checklist: