session-info: add new fields + migration #4545

ordian · 2021-12-16T17:05:25Z

This PR adds new fields to SessionInfo module in preparation for implementing dispute offences and validator disabling.
In order to disable a validator, we need an index into the original set, not the one reduced to (shuffled) parachain validators.

~~is moving ParachainHost to v2 gonna cause problems?~~
confirm it's working (test?)
fix failing tests

cumulus companion: paritytech/cumulus#875

* master: pvf-precheck: Integrate PVF pre-checking into paras module (#4457)

* master: Fix fmt on master (#4546) Support new version of zombienet (#4528) naming consistency (#4539) paras: add log target (#4478)

…kadot into ao-session-info-migration * 'ao-session-info-migration' of github.com:paritytech/polkadot:

* master: dispute-coordinator: fix underflow panic (#4557) Bump futures from 0.3.18 to 0.3.19 (#4567) Bump lru from 0.7.0 to 0.7.1 (#4566) Update Polkadot (#4561) Suggest installing graphviz before book building (#4565) [Zombienet] fix test creds (#4562) chain-api: stop ancestors lookup at block #0 (#4560) use v1.0.2 of zombienet (#4553) remove invalid dispute subsystem replace (#4559) Bump hyper from 0.14.15 to 0.14.16 (#4550) Create a README for XCMv2 detailing notable changes (#4059) enable disputes for known chains, except for polkadot (#4464) dispute statements node side limiting (#4541) Bump serde from 1.0.131 to 1.0.132 (#4551) Bump nix from 0.23.0 to 0.23.1 (#4552) Dispute coordinator: look for included candidates in non-finalized chain (#4508)

runtime/parachains/src/session_info/migration.rs

* master: Fix currently-checking-cache (#4410) Companion for Substrate#10445 (#4506) pvf-precheck: update rustdoc for paras module (#4459)

drahnr

Looks good to me. I'd argue we eventually want to find a more streamlined way of versioning (which is mostly expanding structs) beyond copying structs and adding fields. Not sure if nesting is the best thing either. A discussion to be had in the future. I digress. LGTM

drahnr · 2021-12-22T16:00:47Z

node/core/approval-voting/src/tests.rs

@@ -740,6 +740,22 @@ impl ChainBuilder {
 	}
 }

+fn session_info(keys: &[Sr25519Keyring]) -> SessionInfo {


We should probably prefix this with dummy_ or make_ to make it explicit this is only every used for test and not some internal fn.

Agree, although this is a private function in tests module :P

Should have Prefix It With "Micro nit:" 🌻

ordian · 2021-12-22T16:44:56Z

bumping to medium priority, because we want validators to update before the runtime is enacted
thanks to @pepyakin for bringing this up

ordian · 2021-12-22T18:00:16Z

bot merge

paritytech-processbot · 2021-12-22T18:00:24Z

Error: It's not possible to meet the minimal approval count of 1 in paritytech/cumulus#872

ordian · 2021-12-27T08:01:19Z

bot merge

* companion for paritytech/polkadot#4545 * update lockfile for polkadot Co-authored-by: parity-processbot <>

* master: make check-dependent-* only be executed in PRs (#4588) session_info: add dispute_period and random_seed (#4547) session-info: add new fields + migration (#4545) Bump zstd from 0.9.0+zstd.1.5.0 to 0.9.1+zstd.1.5.1 (#4597) Relaunch Rococo (#4577) Companion for substrate#9732 (#4104) Better logs and metrics on PoV fetching. (#4593)

* session_info: v2 + migration * use primitives::v2 * use polkadot_primitives::v2 * impl primitives::v2 * fix approval-voting tests * fix other tests * hook storage migration up * backwards compat (1) * backwards compat (2) * fmt * fix tests * FMT * do not reexport v1 in v2 * fmt * set storage version to 1 Co-authored-by: Javier Viola <[email protected]>

* companion for paritytech/polkadot#4545 * update lockfile for polkadot Co-authored-by: parity-processbot <>

ordian added 10 commits December 16, 2021 16:36

session_info: v2 + migration

7a09ba6

use primitives::v2

a244132

use polkadot_primitives::v2

f3bea27

impl primitives::v2

cc0ec5d

fix approval-voting tests

a7374a2

fix other tests

e010ce1

hook storage migration up

d31e3c9

backwards compat (1)

ea2137e

Merge branch 'master' into ao-session-info-migration

e10093c

* master: pvf-precheck: Integrate PVF pre-checking into paras module (#4457)

backwards compat (2)

8a53e57

ordian added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. labels Dec 16, 2021

github-actions bot added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Dec 16, 2021

ordian added the D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. label Dec 16, 2021

ordian and others added 4 commits December 16, 2021 18:19

fmt

db4b2d5

fix tests

0bd8efd

FMT

0b3ae56

Merge branch 'master' into ao-session-info-migration

30ca83b

ordian mentioned this pull request Dec 16, 2021

session-info: add dispute_period and random_seed #4547

Merged

ordian added 6 commits December 16, 2021 19:45

Merge branch 'master' into ao-session-info-migration

dacda5a

* master: Fix fmt on master (#4546) Support new version of zombienet (#4528) naming consistency (#4539) paras: add log target (#4478)

Merge branch 'ao-session-info-migration' of github.com:paritytech/pol…

659e3ad

…kadot into ao-session-info-migration * 'ao-session-info-migration' of github.com:paritytech/polkadot:

everyday we stray further from master

46f9875

do not reexport v1 in v2

4544adf

fmt

9bf0c76

pepyakin reviewed Dec 21, 2021

View reviewed changes

runtime/parachains/src/session_info/migration.rs Outdated Show resolved Hide resolved

runtime/parachains/src/session_info/migration.rs Show resolved Hide resolved

set storage version to 1

75aa29b

Merge branch 'master' into ao-session-info-migration

f51b27d

* master: Fix currently-checking-cache (#4410) Companion for Substrate#10445 (#4506) pvf-precheck: update rustdoc for paras module (#4459)

ordian added a commit to paritytech/cumulus that referenced this pull request Dec 22, 2021

companion for paritytech/polkadot#4545

0700458

ordian mentioned this pull request Dec 22, 2021

companion for polkadot#4545 (session-info v2) paritytech/cumulus#872

Closed

ordian marked this pull request as ready for review December 22, 2021 11:41

ordian added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Dec 22, 2021

drahnr approved these changes Dec 22, 2021

View reviewed changes

ordian added C3-medium PR touches the given topic and has a medium impact on builders. and removed C1-low PR touches the given topic and has a low impact on builders. labels Dec 22, 2021

ordian added a commit to paritytech/cumulus that referenced this pull request Dec 22, 2021

companion for paritytech/polkadot#4545

298a54e

ordian added a commit to paritytech/cumulus that referenced this pull request Dec 22, 2021

companion for paritytech/polkadot#4545

0783711

ordian mentioned this pull request Dec 22, 2021

companion for polkadot#4545 (session-info v2) paritytech/cumulus#875

Merged

paritytech-processbot bot merged commit 6eacc1f into master Dec 27, 2021

paritytech-processbot bot deleted the ao-session-info-migration branch December 27, 2021 08:01

paritytech-processbot bot pushed a commit to paritytech/cumulus that referenced this pull request Dec 27, 2021

companion for polkadot#4545 (session-info v2) (#875)

9cbc629

* companion for paritytech/polkadot#4545 * update lockfile for polkadot Co-authored-by: parity-processbot <>

librelois mentioned this pull request Feb 7, 2022

Update substrate/polkadot/cumulus from v0.9.15 to v0.9.16 moonbeam-foundation/moonbeam#1259

Closed

drahnr mentioned this pull request Feb 16, 2022

[DO NOT MERGE] zer0-nine-fifteen-plus-session-info #4929

Closed

louismerlin added D1-audited 👍 PR contains changes to critical logic that has been properly reviewed and externally audited. and removed D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jul 5, 2022

WebWizrd8 added a commit to WebWizrd8/cumulus that referenced this pull request Nov 21, 2022

companion for polkadot#4545 (session-info v2) (#875)

8cb6c8f

* companion for paritytech/polkadot#4545 * update lockfile for polkadot Co-authored-by: parity-processbot <>

s0me0ne-unkn0wn mentioned this pull request Feb 15, 2023

Retire OldV1SessionInfo #6722

Closed

saraswatpuneet mentioned this pull request Feb 15, 2023

Schema BitFlags: Enable fine grained schema controls via optional settings frequency-chain/frequency#1079

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

session-info: add new fields + migration #4545

session-info: add new fields + migration #4545

ordian commented Dec 16, 2021 •

edited

Loading

drahnr left a comment

drahnr Dec 22, 2021

ordian Dec 22, 2021

drahnr Dec 22, 2021 •

edited

Loading

ordian commented Dec 22, 2021

ordian commented Dec 22, 2021

paritytech-processbot bot commented Dec 22, 2021

ordian commented Dec 27, 2021

session-info: add new fields + migration #4545

session-info: add new fields + migration #4545

Conversation

ordian commented Dec 16, 2021 • edited Loading

drahnr left a comment

Choose a reason for hiding this comment

drahnr Dec 22, 2021

Choose a reason for hiding this comment

ordian Dec 22, 2021

Choose a reason for hiding this comment

drahnr Dec 22, 2021 • edited Loading

Choose a reason for hiding this comment

ordian commented Dec 22, 2021

ordian commented Dec 22, 2021

paritytech-processbot bot commented Dec 22, 2021

ordian commented Dec 27, 2021

ordian commented Dec 16, 2021 •

edited

Loading

drahnr Dec 22, 2021 •

edited

Loading