This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Create a README for XCMv2 detailing notable changes #4059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
added
A0-please_review
KiChjang
requested review from
gavofyork,
shawntabrizi,
kianenigma and
apopiak
|
btw. if the content is the same you could potentially just use https://github.com/livioribeiro/cargo-readme to generate the readme.md |
shawntabrizi
approved these changes
Dec 18, 2021
Comment on lines
-3
to
-7
|
|
||
| ## Changes to be aware of | ||
| Most changes should automatically be resolved via the conversion traits (i.e. `TryFrom` and `From`). The list here is mostly for incompatible changes that result in an `Err(())` when attempting to convert XCM objects from v0. | ||
|
|
||
| ### Junction |
There was a problem hiding this comment.
There was a discussion where we agreed that we shouldn't maintain duplicated information on 2 different locations (i.e. both on the README.md and the top-level doc comments for the Rust module), and so I opted for only writing it on the top-level doc comments.
|
bot merge |
ordian
added a commit
that referenced
this pull request
Dec 20, 2021
* master: dispute-coordinator: fix underflow panic (#4557) Bump futures from 0.3.18 to 0.3.19 (#4567) Bump lru from 0.7.0 to 0.7.1 (#4566) Update Polkadot (#4561) Suggest installing graphviz before book building (#4565) [Zombienet] fix test creds (#4562) chain-api: stop ancestors lookup at block #0 (#4560) use v1.0.2 of zombienet (#4553) remove invalid dispute subsystem replace (#4559) Bump hyper from 0.14.15 to 0.14.16 (#4550) Create a README for XCMv2 detailing notable changes (#4059) enable disputes for known chains, except for polkadot (#4464) dispute statements node side limiting (#4541) Bump serde from 1.0.131 to 1.0.132 (#4551) Bump nix from 0.23.0 to 0.23.1 (#4552) Dispute coordinator: look for included candidates in non-finalized chain (#4508)
drahnr
pushed a commit
that referenced
this pull request
Jan 4, 2022
* Create a README for XCMv2 detailing notable changes * Typo * Appease spellcheck and cargo fmt * Add XCM pallet item to be aware of * cargo fmt * Remove all XCM README.md
Wizdave97
pushed a commit
to ComposableFi/polkadot
that referenced
this pull request
Feb 3, 2022
* Create a README for XCMv2 detailing notable changes * Typo * Appease spellcheck and cargo fmt * Add XCM pallet item to be aware of * cargo fmt * Remove all XCM README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.