Schema BitFlags: Enable fine grained schema controls via optional settings #1079
Conversation
saraswatpuneet
changed the title
saraswatpuneet
changed the title
There was a problem hiding this comment.
Overall I think there is some confusion around the naming. We already have something called Grants for a schema--it is the grant of a specific permission on a schema to a delegate.
What we are adding here are schema properties or attributes, that apply to the schema as a whole, not just an individual delegate.
Maybe instead of Grant we call it a SchemaProperty?
Please let me know if I'm misunderstanding this...
|
@JoeCap08055 when we initially worked on schemas, we said permission are nothing but schemas delegation (publishing rights) , Grants we discussed to be called to schema level controls. |
| }) | ||
| }); | ||
| weight | ||
| } |
There was a problem hiding this comment.
For safety reasons, a migration hook should be designed to be idempotent even if you expect to remove it before the next runtime upgrade. There should be some check like for if it's OldSchema or not before calling translate_values.
pallets/schemas/src/lib.rs
Outdated
| migrations::migrate_schemas_with_additional_settings::<T>() | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
try-runtime is meant to be used for testing, esp. storage migrations. If you have a look at the remove sudo storage PR it has a bunch of logging in the try-runtime, but logging is a good idea anyway in case something goes wrong.
| // ============================================== | ||
| // END RUNTIME STORAGE MIGRATION: Schemas | ||
| // ============================================== | ||
|
|
There was a problem hiding this comment.
@shannonwells tested with this and works fine, i see schemas migrated
| @@ -143,6 +150,7 @@ pub mod pallet { | |||
|
|
|||
| #[pallet::pallet] | |||
| #[pallet::generate_store(pub(super) trait Store)] | |||
| #[pallet::storage_version(SCHEMA_STORAGE_VERSION)] | |||
There was a problem hiding this comment.
Storage version will be checked at the time of migration and anything older will be translated while newer ignored
There was a problem hiding this comment.
I'm curious how this works under the hood. Just want to make sure there are no surprises
| @@ -143,6 +150,7 @@ pub mod pallet { | |||
|
|
|||
| #[pallet::pallet] | |||
| #[pallet::generate_store(pub(super) trait Store)] | |||
| #[pallet::storage_version(SCHEMA_STORAGE_VERSION)] | |||
There was a problem hiding this comment.
I'm curious how this works under the hood. Just want to make sure there are no surprises
Goal
The goal of this PR is :-
SchemaSettings: Enable fine grained schema controls via optional settings
This PR addressed updating schemas pallet and all the dependent code/tests to be updated
With @aramikm
Creates : #1106
Closes : #1020
Discussion
Checklist