export xcm_pallet config #4116

GopherJ · 2021-10-21T03:15:46Z

Signed-off-by: Cheng JIANG [email protected]

Not sure if I should touch kusama's genesis config, but it can be useful to be able to test against kusama-local

Signed-off-by: Cheng JIANG <[email protected]>

KiChjang

Exporting the Config part from XCM pallet is fine, I just want to ensure that we're not trying to change any sort of config on Kusama (though it's rather pointless since Kusama's already launched and GenesisConfig won't ever affect it again...)

node/service/src/chain_spec.rs

Signed-off-by: Cheng JIANG <[email protected]>

GopherJ · 2021-10-21T03:32:24Z

Exporting the Config part from XCM pallet is fine, I just want to ensure that we're not trying to change any sort of config on Kusama (though it's rather pointless since Kusama's already launched and GenesisConfig won't ever affect it again...)

yes that's why I changed it, because now I have to test against kusama-local and westend-local is broken with weight issue polkadot-js/apps#6349 (comment)

GopherJ · 2021-10-21T06:43:08Z

polkadot/xcm/pallet-xcm/src/lib.rs

Lines 391 to 394 in 666e67d

pub struct GenesisConfig {

/// The default version to encode outgoing XCM messages with.

pub safe_xcm_version: Option<XcmVersion>,

}
pub struct GenesisConfig<T: Config> {
        /// The default version to encode outgoing XCM messages with.
        pub safe_xcm_version: Option<XcmVersion>,
        pub phantom: sp_std::marker::PhantomData<T>,
}
Can you change this? So can change it in TestExternalities
pallet_xcm::GenesisConfig::<Runtime> {
        safe_xcm_version: Some(2),
        ..Default::default()
}
.assimilate_storage(&mut t)
.unwrap();


.assimilate_storage(&mut t)
    |      ^^^^^^^^^^^^^^^^^^ cannot infer type for type parameter `T` declared on the trait `GenesisBuild`

can you review now to see if it's ok?

xcm/pallet-xcm/src/lib.rs

zjb0807

LGTM. Thanks

zjb0807 · 2021-10-21T08:27:17Z

    #[cfg(feature = "std")]
    impl GenesisConfig {
        /// Direct implementation of `GenesisBuild::build_storage`.
        ///
        /// Kept in order not to break dependency.
        pub fn build_storage<T: Config>(&self) -> Result<sp_runtime::Storage, String> {
            <Self as frame_support::traits::GenesisBuild<T>>::build_storage(self)
        }

        /// Direct implementation of `GenesisBuild::assimilate_storage`.
        ///
        /// Kept in order not to break dependency.
        pub fn assimilate_storage<T: Config>(
            &self,
            storage: &mut sp_runtime::Storage,
        ) -> Result<(), String> {
            <Self as frame_support::traits::GenesisBuild<T>>::assimilate_storage(self, storage)
        }
    }

    pallet_xcm::GenesisConfig { safe_xcm_version: Some(2) }
        .assimilate_storage::<Test>(&mut t)
        .unwrap();

The implementation of GenesisBuild::assimilate_storage avoide PhantomData.

xcm/pallet-xcm/src/lib.rs

kianenigma

Can't genesis remain not generic?

KiChjang · 2021-10-21T18:39:10Z

polkadot/xcm/pallet-xcm/src/lib.rs

Lines 391 to 394 in 666e67d

pub struct GenesisConfig {

/// The default version to encode outgoing XCM messages with.

pub safe_xcm_version: Option<XcmVersion>,

}
pub struct GenesisConfig<T: Config> {
        /// The default version to encode outgoing XCM messages with.
        pub safe_xcm_version: Option<XcmVersion>,
        pub phantom: sp_std::marker::PhantomData<T>,
}
Can you change this? So can change it in TestExternalities
pallet_xcm::GenesisConfig::<Runtime> {
        safe_xcm_version: Some(2),
        ..Default::default()
}
.assimilate_storage(&mut t)
.unwrap();


.assimilate_storage(&mut t)
    |      ^^^^^^^^^^^^^^^^^^ cannot infer type for type parameter `T` declared on the trait `GenesisBuild`

@zjb0807 I'm actually unsure why you're hitting this issue, but I don't think adding a type parameter to GenesisConfig solves your problem, in fact it looks to me like a hack if it did "accidentally" solve your issue.

zjb0807 · 2021-10-22T00:28:36Z

@zjb0807 I'm actually unsure why you're hitting this issue, but I don't think adding a type parameter to GenesisConfig solves your problem, in fact it looks to me like a hack if it did "accidentally" solve your issue.

I realized that this is not good, so I suggested this way again.

    #[cfg(feature = "std")]
    impl GenesisConfig {
        /// Direct implementation of `GenesisBuild::build_storage`.
        ///
        /// Kept in order not to break dependency.
        pub fn build_storage<T: Config>(&self) -> Result<sp_runtime::Storage, String> {
            <Self as frame_support::traits::GenesisBuild<T>>::build_storage(self)
        }

        /// Direct implementation of `GenesisBuild::assimilate_storage`.
        ///
        /// Kept in order not to break dependency.
        pub fn assimilate_storage<T: Config>(
            &self,
            storage: &mut sp_runtime::Storage,
        ) -> Result<(), String> {
            <Self as frame_support::traits::GenesisBuild<T>>::assimilate_storage(self, storage)
        }
    }

    pallet_xcm::GenesisConfig { safe_xcm_version: Some(2) }
        .assimilate_storage::<Test>(&mut t)
        .unwrap();

The implementation of GenesisBuild::assimilate_storage avoide PhantomData.

KiChjang

@GopherJ Can we revert the changes that made GenesisConfig generic?

This reverts commit 4405ea9.

GopherJ · 2021-10-22T01:44:19Z

@GopherJ Can we revert the changes that made GenesisConfig generic?

done

zjb0807 · 2021-10-22T01:51:48Z

@GopherJ Can we revert the changes that made GenesisConfig generic?

done

Can you help add this implementation?

    #[cfg(feature = "std")]
    impl GenesisConfig {
        /// Direct implementation of `GenesisBuild::build_storage`.
        ///
        /// Kept in order not to break dependency.
        pub fn build_storage<T: Config>(&self) -> Result<sp_runtime::Storage, String> {
            <Self as frame_support::traits::GenesisBuild<T>>::build_storage(self)
        }

        /// Direct implementation of `GenesisBuild::assimilate_storage`.
        ///
        /// Kept in order not to break dependency.
        pub fn assimilate_storage<T: Config>(
            &self,
            storage: &mut sp_runtime::Storage,
        ) -> Result<(), String> {
            <Self as frame_support::traits::GenesisBuild<T>>::assimilate_storage(self, storage)
        }
    }

    pallet_xcm::GenesisConfig { safe_xcm_version: Some(2) }
        .assimilate_storage::<Test>(&mut t)
        .unwrap();

The implementation of GenesisBuild::assimilate_storage avoide PhantomData.

KiChjang · 2021-10-22T02:15:00Z

@zjb0807 Sorry, what exactly is going on here? Are you asking for a technical support, or are you suggesting a change on this PR?

zjb0807 · 2021-10-22T02:18:31Z

@zjb0807 Sorry, what exactly is going on here? Are you asking for a technical support, or are you suggesting a change on this PR?

I want to modify the genesis config in TestExternalities.

pallet_xcm::GenesisConfig { safe_xcm_version: Some(2) }
        .assimilate_storage::<Test>(&mut t)
        .unwrap();

KiChjang · 2021-10-22T02:21:30Z

@zjb0807 And why are you asking about that here in this PR?

zjb0807 · 2021-10-22T02:23:12Z

@zjb0807 And why are you asking about that here in this PR?

Ok. You can approve the PR and I'll do it through another PR.

KiChjang · 2021-10-22T02:25:49Z

bot merge

GopherJ · 2021-10-22T02:27:22Z

@zjb0807 And why are you asking about that here in this PR?

Ok. You can approve the PR and I'll do it through another PR.

yes that'll maybe be easier because I didn't understand it yet sorry didn't help:)

* master: (73 commits) Fix XCM Teleport Benchmark (#4146) Allow Queries and Subscriptions (#4150) Fix weights on hard-coded XCM fragments (#4144) Bump spec versions (#4142) Bump libc from 0.2.104 to 0.2.105 (#4141) Enable bags-list pallet in polkadot (#4080) Move artifacts states into memory in PVF validation host (#3907) Introduce new Runtime API endpoint for fetching the validation data (#3728) export xcm_pallet config (#4116) Apply cargo fmt (#4122) remove logging from the check-dependent-* job (#4120) Remove stale migrations (#4107) Bump structopt from 0.3.23 to 0.3.25 (#4098) remove hardcoded pipeline scripts tag (#4109) Bump libc from 0.2.103 to 0.2.104 (#4099) some spelling fixes (#4088) polkadot: remove call filters on registrar pallets (#4093) Fix typos in docs (#4092) Rename Statemint where appropriate (#4087) bump substrate (#4091) ...

* export xcm_pallet config Signed-off-by: Cheng JIANG <[email protected]> * run format Signed-off-by: Cheng JIANG <[email protected]> * fix typo Signed-off-by: Cheng JIANG <[email protected]> * add generic parameter to support different runtimes * Revert "add generic parameter to support different runtimes" This reverts commit 4405ea9.

GopherJ added 2 commits October 21, 2021 11:13

export xcm_pallet config

87da125

Signed-off-by: Cheng JIANG <[email protected]>

run format

398d125

Signed-off-by: Cheng JIANG <[email protected]>

KiChjang suggested changes Oct 21, 2021

View reviewed changes

node/service/src/chain_spec.rs Outdated Show resolved Hide resolved

node/service/src/chain_spec.rs Outdated Show resolved Hide resolved

node/service/src/chain_spec.rs Outdated Show resolved Hide resolved

node/service/src/chain_spec.rs Outdated Show resolved Hide resolved

fix typo

dd09741

Signed-off-by: Cheng JIANG <[email protected]>

KiChjang approved these changes Oct 21, 2021

View reviewed changes

KiChjang requested review from shawntabrizi, gavofyork and kianenigma October 21, 2021 03:37

This comment has been minimized.

Sign in to view

add generic parameter to support different runtimes

4405ea9

zjb0807 reviewed Oct 21, 2021

View reviewed changes

xcm/pallet-xcm/src/lib.rs Outdated Show resolved Hide resolved

zjb0807 reviewed Oct 21, 2021

View reviewed changes

KiChjang requested a review from gui1117 October 21, 2021 14:38

apopiak approved these changes Oct 21, 2021

View reviewed changes

xcm/pallet-xcm/src/lib.rs Outdated Show resolved Hide resolved

kianenigma reviewed Oct 21, 2021

View reviewed changes

KiChjang suggested changes Oct 22, 2021

View reviewed changes

Revert "add generic parameter to support different runtimes"

0c01dda

This reverts commit 4405ea9.

GopherJ force-pushed the feat/export-xcm-pallet-config branch from 987b0da to 0c01dda Compare October 22, 2021 01:39

KiChjang approved these changes Oct 22, 2021

View reviewed changes

paritytech-processbot bot merged commit 84466fe into paritytech:master Oct 22, 2021

GopherJ deleted the feat/export-xcm-pallet-config branch October 22, 2021 02:26

ghzlatarev mentioned this pull request Dec 4, 2021

[Manta] Integrate v0.9.13 upstream changes Manta-Network/Manta#294

Merged

23 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

export xcm_pallet config #4116

export xcm_pallet config #4116

GopherJ commented Oct 21, 2021 •

edited

Loading

KiChjang left a comment

GopherJ commented Oct 21, 2021 •

edited

Loading

This comment has been minimized.

GopherJ commented Oct 21, 2021

zjb0807 left a comment

zjb0807 commented Oct 21, 2021

kianenigma left a comment

KiChjang commented Oct 21, 2021

zjb0807 commented Oct 22, 2021

KiChjang left a comment

GopherJ commented Oct 22, 2021

zjb0807 commented Oct 22, 2021

KiChjang commented Oct 22, 2021

zjb0807 commented Oct 22, 2021

KiChjang commented Oct 22, 2021

zjb0807 commented Oct 22, 2021

KiChjang commented Oct 22, 2021

GopherJ commented Oct 22, 2021 •

edited

Loading

export xcm_pallet config #4116

export xcm_pallet config #4116

Conversation

GopherJ commented Oct 21, 2021 • edited Loading

KiChjang left a comment

Choose a reason for hiding this comment

GopherJ commented Oct 21, 2021 • edited Loading

This comment has been minimized.

GopherJ commented Oct 21, 2021

zjb0807 left a comment

Choose a reason for hiding this comment

zjb0807 commented Oct 21, 2021

kianenigma left a comment

Choose a reason for hiding this comment

KiChjang commented Oct 21, 2021

zjb0807 commented Oct 22, 2021

KiChjang left a comment

Choose a reason for hiding this comment

GopherJ commented Oct 22, 2021

zjb0807 commented Oct 22, 2021

KiChjang commented Oct 22, 2021

zjb0807 commented Oct 22, 2021

KiChjang commented Oct 22, 2021

zjb0807 commented Oct 22, 2021

KiChjang commented Oct 22, 2021

GopherJ commented Oct 22, 2021 • edited Loading

GopherJ commented Oct 21, 2021 •

edited

Loading

GopherJ commented Oct 21, 2021 •

edited

Loading

GopherJ commented Oct 22, 2021 •

edited

Loading