This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Enable bags-list pallet in polkadot #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kianenigma
commented
Oct 14, 2021
•
kianenigma
commented
- enables the bags-list pallet in a write-only (safe) mode in polkadot
- adds corresponding migration
- removes stale migrations
- add pallet calls to proxy type for all runtimes.
kianenigma
added
A0-please_review
|
dry-run of migration: |
KiChjang
reviewed
Oct 14, 2021
…kadot into kiz-enable-bags-list-polk
emostov
reviewed
Oct 14, 2021
emostov
reviewed
Oct 14, 2021
| "some data already seem to exist in the bags-list pallet.." | ||
| ); | ||
| } | ||
| <Runtime as pallet_staking::Config>::SortedListProvider::clear(None); |
There was a problem hiding this comment.
Why do we clear here? I think this would mean the test is being applied to a chain which already has voter bags up and running. In this case this test is not relevant. Instead I think we should exit early with a clear message.
In the future for this case we will make somethings that calls migrate(bag thresholds) instead of regenerate
There was a problem hiding this comment.
exiting is also an option, but perhaps you want to re-create the migration. Main point is that we don't double write.
emostov
approved these changes
Oct 14, 2021
redzsina
added
D1-audited 👍
gavofyork
approved these changes
Oct 20, 2021
|
bot merge |
|
Waiting for commit status. |
ordian
added a commit
that referenced
this pull request
Oct 27, 2021
* master: (73 commits) Fix XCM Teleport Benchmark (#4146) Allow Queries and Subscriptions (#4150) Fix weights on hard-coded XCM fragments (#4144) Bump spec versions (#4142) Bump libc from 0.2.104 to 0.2.105 (#4141) Enable bags-list pallet in polkadot (#4080) Move artifacts states into memory in PVF validation host (#3907) Introduce new Runtime API endpoint for fetching the validation data (#3728) export xcm_pallet config (#4116) Apply cargo fmt (#4122) remove logging from the check-dependent-* job (#4120) Remove stale migrations (#4107) Bump structopt from 0.3.23 to 0.3.25 (#4098) remove hardcoded pipeline scripts tag (#4109) Bump libc from 0.2.103 to 0.2.104 (#4099) some spelling fixes (#4088) polkadot: remove call filters on registrar pallets (#4093) Fix typos in docs (#4092) Rename Statemint where appropriate (#4087) bump substrate (#4091) ...
emostov
pushed a commit
that referenced
this pull request
Nov 1, 2021
* Enable bags-list pallet in polkadot * add files * Remove trailing semicolon * more fixes * Update runtime/polkadot/src/lib.rs * add features * remove par Co-authored-by: Keith Yeung <[email protected]> Co-authored-by: Shawn Tabrizi <[email protected]>
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.