Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Move artifacts states into memory in PVF validation host #3907

Merged
merged 12 commits into from
Oct 22, 2021
Merged

Move artifacts states into memory in PVF validation host #3907

merged 12 commits into from
Oct 22, 2021

Conversation

slumber
Copy link
Contributor

@slumber slumber commented Sep 22, 2021

Resolves #3720

@slumber slumber added the A0-please_review Pull request needs code review. label Sep 22, 2021
@slumber slumber force-pushed the slumber-move-artifact-status-into-memory branch from f0943e6 to f271c09 Compare September 23, 2021 10:45
pepyakin
pepyakin reviewed Sep 23, 2021
View reviewed changes
Copy link
Contributor

@pepyakin pepyakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a brief look.

node/core/pvf/src/host.rs Outdated Show resolved Hide resolved
node/core/pvf/src/prepare/worker.rs Outdated Show resolved Hide resolved
pepyakin
pepyakin reviewed Sep 27, 2021
View reviewed changes
node/core/pvf/src/host.rs Outdated Show resolved Hide resolved
node/core/pvf/src/prepare/worker.rs Outdated Show resolved Hide resolved
node/core/pvf/src/error.rs Outdated Show resolved Hide resolved
node/core/pvf/src/prepare/pool.rs Show resolved Hide resolved
node/core/pvf/src/prepare/worker.rs Outdated Show resolved Hide resolved
@slumber slumber added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Sep 27, 2021
@pepyakin pepyakin mentioned this pull request Oct 22, 2021
Merged
pepyakin
pepyakin approved these changes Oct 22, 2021
View reviewed changes
node/core/pvf/src/prepare/queue.rs Outdated Show resolved Hide resolved
node/core/pvf/src/prepare/pool.rs Outdated Show resolved Hide resolved
node/core/pvf/src/prepare/worker.rs Show resolved Hide resolved
@pepyakin
Copy link
Contributor

/cla run-cla-check

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Oct 22, 2021

Queueing command execution: run-cla-check

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Oct 22, 2021

@pepyakin Command execution has finished.

@pepyakin
Copy link
Contributor

bot merge

@paritytech-processbot paritytech-processbot bot merged commit ee1b80a into master Oct 22, 2021
@paritytech-processbot paritytech-processbot bot deleted the slumber-move-artifact-status-into-memory branch October 22, 2021 16:38
ordian added a commit that referenced this pull request Oct 27, 2021
@ordian
Merge branch 'master' into ladi-logging-disputes
44d2b57 
* master: (73 commits)
  Fix XCM Teleport Benchmark (#4146)
  Allow Queries and Subscriptions (#4150)
  Fix weights on hard-coded XCM fragments (#4144)
  Bump spec versions (#4142)
  Bump libc from 0.2.104 to 0.2.105 (#4141)
  Enable bags-list pallet in polkadot (#4080)
  Move artifacts states into memory in PVF validation host (#3907)
  Introduce new Runtime API endpoint for fetching the validation data (#3728)
  export xcm_pallet config (#4116)
  Apply cargo fmt (#4122)
  remove logging from the check-dependent-* job (#4120)
  Remove stale migrations (#4107)
  Bump structopt from 0.3.23 to 0.3.25 (#4098)
  remove hardcoded pipeline scripts tag (#4109)
  Bump libc from 0.2.103 to 0.2.104 (#4099)
  some spelling fixes (#4088)
  polkadot: remove call filters on registrar pallets (#4093)
  Fix typos in docs (#4092)
  Rename Statemint where appropriate (#4087)
  bump substrate (#4091)
  ...
emostov pushed a commit that referenced this pull request Nov 1, 2021
@slumber @pepyakin @emostov
Move artifacts states into memory in PVF validation host (#3907)
19d7c40 
* pvf host: store only compiled artifacts on disk

* Correctly handle failed artifacts

* Serialize result of PVF preparation uniquely

* Set the artifact state depending on the result

* Return the result of PVF preparation directly

* Move PrepareError to the error module

* Update doc comments

* Update misleading comment

* Cleanup docs

* Conclude a test job with an error

Co-authored-by: Sergei Shulepov <[email protected]>
@ghzlatarev ghzlatarev mentioned this pull request Dec 4, 2021
Merged
23 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pepyakin pepyakin pepyakin approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PVF validation host: move artifacts states into memory
2 participants
@slumber @pepyakin