Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

fix restart issue of staking miner #4073

Merged
merged 10 commits into from
Oct 14, 2021
Merged

fix restart issue of staking miner #4073

merged 10 commits into from
Oct 14, 2021

Conversation

kianenigma
Copy link
Contributor

@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Oct 13, 2021
niklasad1
niklasad1 approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm not super familiar with the code

emostov
emostov approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a few comments/ questions

@kianenigma kianenigma merged commit 1844519 into master Oct 14, 2021
@kianenigma kianenigma deleted the kiz-staking-miner-imp branch October 14, 2021 12:12
ordian added a commit that referenced this pull request Oct 14, 2021
@ordian
Merge branch 'master' into bernhard-malus-fx
b3ef403 
* master: (40 commits)
  use pipeline-scripts for dependent projects script (#4017)
  companion for substrate/10013 (#4078)
  fix restart issue of staking miner (#4073)
  use `WEIGHT_PER_SECOND` (#4077)
  Switch to compressed runtimes (#4061)
  Create a README for XCMv1 detailing notable changes (#4058)
  Bump proc-macro2 from 1.0.29 to 1.0.30 (#4071)
  Move runtime to with_transaction in order to Rollback state changes (#4067)
  Update wasmtime config to match new version in substrate (#4063)
  Fix XCM Weights on Westend (#4066)
  Dispatchable XCMs should translate to v0 (#4062)
  Add xcm fuzzer (#3869)
  Bump trybuild from 1.0.49 to 1.0.50 (#4060)
  Companion PR for ss58 crate (#3953)
  overseer: simplify debugging some more (#4053)
  Bump thiserror from 1.0.29 to 1.0.30 (#4048)
  Bump strum from 0.21.0 to 0.22.0 (#4047)
  Add para pallets to polkadot benchmarks (#4045)
  Fixes broken docker link in docker descriptiob (#4043)
  Bump trybuild from 1.0.48 to 1.0.49 (#4039)
  ...
ordian added a commit that referenced this pull request Oct 14, 2021
@ordian
Merge branch 'master' into ao-enable-ApprovalCheckingVotingRule-on-Po…
8ffc548 
…lkadot

* master:
  use pipeline-scripts for dependent projects script (#4017)
  companion for substrate/10013 (#4078)
  fix restart issue of staking miner (#4073)
  use `WEIGHT_PER_SECOND` (#4077)
  Switch to compressed runtimes (#4061)
  Create a README for XCMv1 detailing notable changes (#4058)
  Bump proc-macro2 from 1.0.29 to 1.0.30 (#4071)
emostov pushed a commit that referenced this pull request Nov 1, 2021
@kianenigma @niklasad1 @emostov
fix restart issue of staking miner (#4073)
569c1e6 
Co-authored-by: Niklas Adolfsson <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@emostov emostov emostov approved these changes

@shawntabrizi shawntabrizi Awaiting requested review from shawntabrizi

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kianenigma @niklasad1 @emostov