This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Switch to compressed runtimes #4061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
A3-in_progress
chevdor
added
A2-insubstantial
|
@s3krit I leave this as a draft because I would like to ensure the ruby part works fine but if you confirm, we could merge it and have it, should a new rc be required. |
s3krit
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
LGTM. Manually generated changelog for v0.9.11 to the tip of this branch using the ruby script to verify, as below (rust versions were just what I had in my history so they're probably wrong). srtool JSONs were grabbed from the v0.9.11-rc5 github action run
x@beer [16:43:12] [~/parity/code/polkadot] [wk-switch_to_compressed_runtimes]
% GITHUB_REF=v0.9.11 GITHUB_TOKEN=<redacted> GITHUB_WORKSPACE='..' GITHUB_REPOSITORY='paritytech/polkadot' RUSTC_STABLE='rustc 1.53.0 (53cb7b09b 2021-06-17)' RUSTC_NIGHTLY='rustc 1.53.0-nightly (7f4afdf02 2021-04-22)' ruby scripts/github/generate_release_text.rb
Upgrade priority: **Low** (upgrade at your convenience)
Native runtimes:
- Polkadot: **9120**
- Kusama: **9120**
- Westend: **9120**
This release was tested against the following versions of `rustc`. Other versions may work.
- rustc 1.53.0 (53cb7b09b 2021-06-17)
- rustc 1.53.0-nightly (7f4afdf02 2021-04-22)
WASM runtimes built with [srtool v0.9.17](https://github.com/paritytech/srtool) using `rustc 1.53.0 (53cb7b09b 2021-06-17)`.
Proposal hashes:
* `polkadot_runtime-v9120.compact.compressed.wasm - 0x791e698f3690481e0eb16d35017cf3bb27ec095ec6f27dafd3a230b76dc42f86`
* `kusama_runtime-v9120.compact.compressed.wasm - 0x85b3f283e7f403acc12ce89005f72ccf8d1eb4ff2eab4870f7d345b76c56fb5d`
|
So the main issue I had testing were around having all the ENV properly set, thus the additional simple logger that triggers only when NOT ran by CI so we don't pollute the output with those logs. |
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Oct 14, 2021
* master: (40 commits) use pipeline-scripts for dependent projects script (#4017) companion for substrate/10013 (#4078) fix restart issue of staking miner (#4073) use `WEIGHT_PER_SECOND` (#4077) Switch to compressed runtimes (#4061) Create a README for XCMv1 detailing notable changes (#4058) Bump proc-macro2 from 1.0.29 to 1.0.30 (#4071) Move runtime to with_transaction in order to Rollback state changes (#4067) Update wasmtime config to match new version in substrate (#4063) Fix XCM Weights on Westend (#4066) Dispatchable XCMs should translate to v0 (#4062) Add xcm fuzzer (#3869) Bump trybuild from 1.0.49 to 1.0.50 (#4060) Companion PR for ss58 crate (#3953) overseer: simplify debugging some more (#4053) Bump thiserror from 1.0.29 to 1.0.30 (#4048) Bump strum from 0.21.0 to 0.22.0 (#4047) Add para pallets to polkadot benchmarks (#4045) Fixes broken docker link in docker descriptiob (#4043) Bump trybuild from 1.0.48 to 1.0.49 (#4039) ...
ordian
added a commit
that referenced
this pull request
Oct 14, 2021
…lkadot * master: use pipeline-scripts for dependent projects script (#4017) companion for substrate/10013 (#4078) fix restart issue of staking miner (#4073) use `WEIGHT_PER_SECOND` (#4077) Switch to compressed runtimes (#4061) Create a README for XCMv1 detailing notable changes (#4058) Bump proc-macro2 from 1.0.29 to 1.0.30 (#4071)
emostov
pushed a commit
that referenced
this pull request
Nov 1, 2021
* Remove the upload of the non compressed runtimes * Fix template * Add loggin for local testing * Keep simple logger but remove the need for another dependency
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switch from using the non compressed runtimes by default to using the compressed runtimes.