This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Create a README for XCMv1 detailing notable changes #4058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
added
A0-please_review
gavofyork
reviewed
Oct 12, 2021
gavofyork
approved these changes
Oct 12, 2021
dvdplm
reviewed
Oct 12, 2021
Co-authored-by: Gavin Wood <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
|
Do we want to add this to the module level rust docs as well? |
apopiak
approved these changes
Oct 13, 2021
|
|
||
| ### Order | ||
| - `v1::Order::DepositAsset` and `v1::Order::DepositReserveAsset` both introduced a new `max_asset` field that limits the maximum classes of assets that can be deposited. During conversion from v0, the `max_asset` field defaults to 1. | ||
| - v1 Orders that contain `MultiAsset` as argument(s) will need to explicitly specify the amount and details of assets. This is to prevent accidental misuse of `All` to possibly transfer, spend or otherwise perform unintended operations on `All` assets. |
There was a problem hiding this comment.
Suggested change
| - v1 Orders that contain `MultiAsset` as argument(s) will need to explicitly specify the amount and details of assets. This is to prevent accidental misuse of `All` to possibly transfer, spend or otherwise perform unintended operations on `All` assets. | |
| - v1 Orders that contain `MultiAsset`(s) as argument(s) will need to explicitly specify the amount and details of assets. This is to prevent accidental misuse of `All` to possibly transfer, spend or otherwise perform unintended operations on `All` assets. |
|
bot merge |
|
Trying merge. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Oct 14, 2021
* master: (40 commits) use pipeline-scripts for dependent projects script (#4017) companion for substrate/10013 (#4078) fix restart issue of staking miner (#4073) use `WEIGHT_PER_SECOND` (#4077) Switch to compressed runtimes (#4061) Create a README for XCMv1 detailing notable changes (#4058) Bump proc-macro2 from 1.0.29 to 1.0.30 (#4071) Move runtime to with_transaction in order to Rollback state changes (#4067) Update wasmtime config to match new version in substrate (#4063) Fix XCM Weights on Westend (#4066) Dispatchable XCMs should translate to v0 (#4062) Add xcm fuzzer (#3869) Bump trybuild from 1.0.49 to 1.0.50 (#4060) Companion PR for ss58 crate (#3953) overseer: simplify debugging some more (#4053) Bump thiserror from 1.0.29 to 1.0.30 (#4048) Bump strum from 0.21.0 to 0.22.0 (#4047) Add para pallets to polkadot benchmarks (#4045) Fixes broken docker link in docker descriptiob (#4043) Bump trybuild from 1.0.48 to 1.0.49 (#4039) ...
ordian
added a commit
that referenced
this pull request
Oct 14, 2021
…lkadot * master: use pipeline-scripts for dependent projects script (#4017) companion for substrate/10013 (#4078) fix restart issue of staking miner (#4073) use `WEIGHT_PER_SECOND` (#4077) Switch to compressed runtimes (#4061) Create a README for XCMv1 detailing notable changes (#4058) Bump proc-macro2 from 1.0.29 to 1.0.30 (#4071)
emostov
pushed a commit
that referenced
this pull request
Nov 1, 2021
* Create a README for XCMv1 detailing notable changes * Update xcm/src/v1/README.md Co-authored-by: Gavin Wood <[email protected]> * Update xcm/src/v1/README.md Co-authored-by: David <[email protected]> * Update xcm/src/v1/README.md Co-authored-by: David <[email protected]> * Update xcm/src/v1/README.md Co-authored-by: David <[email protected]> * Update xcm/src/v1/README.md Co-authored-by: David <[email protected]> * Link to relevant PR for a full list of changes * Typo * Add notable changes to top-level XCM rustdoc * Appease spellchecker Co-authored-by: Gavin Wood <[email protected]> Co-authored-by: David <[email protected]>
19 tasks
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent something similar to #4056 happening, I've created a README file to document the notable changes that XCM authors should be aware of when they're upgrading from v0.
A README for XCMv2 changes will follow in another PR.