Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for substrate#9711 #3801

Merged
6 commits merged into from
Sep 14, 2021
Merged

Companion for substrate#9711 #3801

6 commits merged into from
Sep 14, 2021

Conversation

koushiro
Copy link
Contributor

@koushiro koushiro commented Sep 7, 2021

Companion for paritytech/substrate#9711

migrate the pallet-tips storage prefix (Treasury ==> Tips).

Signed-off-by: koushiro <[email protected]>
@gui1117 gui1117 added A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Sep 7, 2021
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I tested with try-runtime on polkadot and on kusama, and it was successful

@shawntabrizi
Copy link
Member

This will need to be merged with the bounties migration PR

@gui1117
Copy link
Contributor

gui1117 commented Sep 13, 2021

This will need to be merged with the bounties migration PR

what do you mean ? I think both can be applied independently, I was thinking merging to master now

@shawntabrizi
Copy link
Member

shawntabrizi commented Sep 13, 2021

i just mean there will be git merge conflicts

@ghost
Copy link

ghost commented Sep 14, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Sep 14, 2021

Merge aborted: Head SHA changed from 7e9dad7 to 57533cc

@shawntabrizi
Copy link
Member

bot merge

@ghost
Copy link

ghost commented Sep 14, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Sep 14, 2021

Merge aborted: Checks failed for 57533cc

@gui1117
Copy link
Contributor

gui1117 commented Sep 14, 2021

bot merge

@ghost
Copy link

ghost commented Sep 14, 2021

Trying merge.

@ghost ghost merged commit 77e92ca into paritytech:master Sep 14, 2021
@koushiro koushiro deleted the migrate-pallet-tips branch September 14, 2021 08:59
ordian added a commit that referenced this pull request Sep 14, 2021
* master:
  Bump tracing from 0.1.26 to 0.1.27 (#3841)
  Companion for substrate#9711 (#3801)
  fix complaints in CI (#3838)
  dockerfiles: upgrade to ubuntu:20.04; some chore (#3828)
  make polkadot-runtime optional feature (#3820)
  Companion for #9648 (#3757)
  Substrate Companion #9737 (#3830)
  Add logging for worker spawn failures (#3827)
  Add Canvas (#3823)
  Allow staking miner to use different election algorithms (#3752)
ordian added a commit that referenced this pull request Sep 15, 2021
* master: (21 commits)
  Add build with docker info to README (#3843)
  improve approval tracing (#3846)
  UMP: Support Overweight messages (#3575)
  Companion for substrate#9115 (#3265)
  Better error messages. (#3835)
  Put all authorities of a session into `SessionInfo`. (#3813)
  Bump tracing from 0.1.26 to 0.1.27 (#3841)
  Companion for substrate#9711 (#3801)
  fix complaints in CI (#3838)
  dockerfiles: upgrade to ubuntu:20.04; some chore (#3828)
  make polkadot-runtime optional feature (#3820)
  Companion for #9648 (#3757)
  Substrate Companion #9737 (#3830)
  Add logging for worker spawn failures (#3827)
  Add Canvas (#3823)
  Allow staking miner to use different election algorithms (#3752)
  Do not expire HRMP open channel requests (#3543)
  Bump tokio from 1.10.1 to 1.11.0 (#3821)
  Add words to the dictionnary (#3819)
  Add vault secrets to puplish-rustdoc job (#3816)
  ...
ordian added a commit that referenced this pull request Sep 16, 2021
* master:
  Raised nits on #3813 (#3844)
  Don't try to connect to ourselves. (#3855)
  add dispute metrics, some chores (#3842)
  add type info derive to senderror (#3860)
  Companion for #8615: enrich metadata with type information (#3336)
  approval-voting: processed wakeups can also update approval state (#3848)
  Add build with docker info to README (#3843)
  improve approval tracing (#3846)
  UMP: Support Overweight messages (#3575)
  Companion for substrate#9115 (#3265)
  Better error messages. (#3835)
  Put all authorities of a session into `SessionInfo`. (#3813)
  Bump tracing from 0.1.26 to 0.1.27 (#3841)
  Companion for substrate#9711 (#3801)
  fix complaints in CI (#3838)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants