This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Migrate pallet-tips to the new pallet attribute macro
#9711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: koushiro <[email protected]>
gui1117
added
A0-please_review
gui1117
approved these changes
Sep 7, 2021
| use frame_system::pallet_prelude::*; | ||
|
|
||
| /// The current storage version. | ||
| const STORAGE_VERSION: StorageVersion = StorageVersion::new(4); |
There was a problem hiding this comment.
when not specified the storage version is 0, so we can use 1 here instead of 4. but 4 is fine too
Signed-off-by: koushiro <[email protected]>
shawntabrizi
approved these changes
Sep 13, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit 
5 tasks
11 tasks
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7882
Migrate the
pallet-tipsto the new pallet attribute macroFrom https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the pallet must be careful about the name they used in
construct_runtime!. Hence theruntime-migrationlabel, which might not be needed depending on the configuration of the pallet.polkadotandkusamauseTipsas pallet name (but the current module_prefix isTreasury), thus need to migrate the storages.polkadot companion: paritytech/polkadot#3801