-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant XCMs from dry run's forwarded xcms #5913
Conversation
bot fmt |
@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7502715 was started for your command Comment |
@franciscoaguirre Command |
there are a few failing tests ( |
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-5913-to-stable2407
git worktree add --checkout .worktree/backport-5913-to-stable2407 backport-5913-to-stable2407
cd .worktree/backport-5913-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 4a70b2cffb23db148a9af50cfbf13c4655dbaf7b
git push --force-with-lease |
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-5913-to-stable2409
git worktree add --checkout .worktree/backport-5913-to-stable2409 backport-5913-to-stable2409
cd .worktree/backport-5913-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 4a70b2cffb23db148a9af50cfbf13c4655dbaf7b
git push --force-with-lease |
* master: (28 commits) `substrate-node`: removed excessive polkadot-sdk features (#5925) Rename QueueEvent::StartWork (#6015) [ci] Remove quick-benchmarks-omni from GitLab (#6014) Set larger timeout for cmd.yml (#6006) Fix `0003-beefy-and-mmr` test (#6003) Remove redundant XCMs from dry run's forwarded xcms (#5913) Add RadiumBlock bootnodes to Coretime Polkadot Chain spec (#5967) Bump strum from 0.26.2 to 0.26.3 (#5943) Add PVF execution priority (#4837) Snowbridge V2 docs (#5902) Fix u256 conversion in BABE (#5994) [ci] Move test-linux-stable-no-try-runtime to GHA (#5979) Bump PoV request timeout (#5924) [Release/CI] Github flow to build `polkadot`/`polkadot-parachain` rc binaries and deb package (#5963) [ci] Remove short-benchmarks from Gitlab (#5988) Disable flaky tests reported in 5972/5973/5974 (#5976) Bump some dependencies (#5886) bump zombienet version and set request for k8s (#5968) [omni-bencher] Make all runtimes work (#5872) Omni-Node renamings (#5915) ...
Backport #5913 into `stable2409` from franciscoaguirre. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Francisco Aguirre <[email protected]>
Backport #5913 into `stable2407` from franciscoaguirre. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Francisco Aguirre <[email protected]> Co-authored-by: Egor_P <[email protected]>
Backport #5913 into `stable2407` from franciscoaguirre. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Francisco Aguirre <[email protected]> Co-authored-by: Egor_P <[email protected]>
Description
This PR addresses #5878.
After dry running an xcm on asset hub, we had redundant xcms showing up in the
forwarded_xcms
field of the dry run effects returned.These were caused by two things:
UpwardMessageSender
router always added an element even if there were no messages.In order to fix this, we check for no messages in UMP and clear the implementation of
InspectMessageQueues
for these bridging routers.Keep in mind that the bridged message is still sent, as normal via the xcmp-queue to Bridge Hub.
To keep on dry-running the journey of the message, the next hop to dry-run is Bridge Hub.
That'll be tackled in a different PR.
Added a test in
bridge-hub-westend-integration-tests
andbridge-hub-rococo-integration-tests
that show that dry-running a transfer across the bridge from asset hub results in one and only one message sent to bridge hub.TODO