Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2407] Backport #5913 #6004

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #5913 into stable2407 from franciscoaguirre.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-5913-to-stable2407
git worktree add --checkout .worktree/backport-5913-to-stable2407 backport-5913-to-stable2407
cd .worktree/backport-5913-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 4a70b2cffb23db148a9af50cfbf13c4655dbaf7b
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Oct 10, 2024
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Oct 10, 2024
@franciscoaguirre franciscoaguirre marked this pull request as ready for review October 10, 2024 12:58
@franciscoaguirre franciscoaguirre requested a review from a team as a code owner October 10, 2024 12:58
@paritytech-review-bot paritytech-review-bot bot requested a review from a team October 10, 2024 12:59
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7555844

@franciscoaguirre franciscoaguirre merged commit 47155f8 into stable2407 Oct 15, 2024
121 of 160 checks passed
@franciscoaguirre franciscoaguirre deleted the backport-5913-to-stable2407 branch October 15, 2024 20:29
franciscoaguirre added a commit that referenced this pull request Oct 25, 2024
Backport #5913 into `stable2407` from franciscoaguirre.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Co-authored-by: Francisco Aguirre <[email protected]>
Co-authored-by: Egor_P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch. T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants