-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump some dependencies #5886
Bump some dependencies #5886
Conversation
This bumps `ethbloom`, `ethereum-types`, `primitive-types` and `rlp` to their latest version. Fixes: #5870
bot fmt |
@skunert https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7475406 was started for your command Comment |
@skunert Command |
Cargo.lock
Outdated
"hashbrown 0.12.3", | ||
"impl-trait-for-tuples", | ||
"lru 0.8.1", | ||
"parity-util-mem-derive", | ||
"parking_lot 0.12.3", | ||
"primitive-types", | ||
"primitive-types 0.12.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're still using parity-util-mem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be removed as in https://github.com/paritytech/polkadot-sdk/pull/5673/files
This bumps `ethbloom`, `ethereum-types`, `primitive-types` and `rlp` to their latest version. Fixes: paritytech#5870 --------- Co-authored-by: command-bot <> Co-authored-by: ggwpez <ggwpez@users.noreply.github.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Dónal Murray <donal.murray@parity.io>
This bumps `ethbloom`, `ethereum-types`, `primitive-types` and `rlp` to their latest version. Fixes: paritytech#5870 --------- Co-authored-by: command-bot <> Co-authored-by: ggwpez <ggwpez@users.noreply.github.com> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Dónal Murray <donal.murray@parity.io>
@@ -108,7 +108,8 @@ pub(super) fn secondary_slot_author( | |||
return None | |||
} | |||
|
|||
let rand = U256::from((randomness, slot).using_encoded(sp_crypto_hashing::blake2_256)); | |||
let rand = | |||
U256::from_little_endian(&(randomness, slot).using_encoded(sp_crypto_hashing::blake2_256)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasn't From::from
based on from_big_endian
?
see https://github.com/paritytech/parity-common/pull/859/files
can this create consensus problems with some nodes upgrading to this code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is causing the failures in some tests.
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7540617
https://grafana.teleport.parity.io/goto/P4omWXkHR?orgId=1
--
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7540639
https://grafana.teleport.parity.io/goto/8xYZZXkNg?orgId=1
--
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7540550
https://grafana.teleport.parity.io/goto/WvoIZXkNR?orgId=1
--
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7540540
https://grafana.teleport.parity.io/goto/0uUHWuzHR?orgId=1
--
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7540189
https://grafana.teleport.parity.io/goto/6PeOZXkHR?orgId=1
--
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7540084
https://grafana.teleport.parity.io/goto/jWV5ZXzNR?orgId=1
--
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7539899
https://grafana.teleport.parity.io/goto/yjEpWukHR?orgId=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#5886 (comment) --------- Co-authored-by: Bastian Köcher <info@kchr.de> Co-authored-by: Bastian Köcher <git@kchr.de>
* master: (28 commits) `substrate-node`: removed excessive polkadot-sdk features (#5925) Rename QueueEvent::StartWork (#6015) [ci] Remove quick-benchmarks-omni from GitLab (#6014) Set larger timeout for cmd.yml (#6006) Fix `0003-beefy-and-mmr` test (#6003) Remove redundant XCMs from dry run's forwarded xcms (#5913) Add RadiumBlock bootnodes to Coretime Polkadot Chain spec (#5967) Bump strum from 0.26.2 to 0.26.3 (#5943) Add PVF execution priority (#4837) Snowbridge V2 docs (#5902) Fix u256 conversion in BABE (#5994) [ci] Move test-linux-stable-no-try-runtime to GHA (#5979) Bump PoV request timeout (#5924) [Release/CI] Github flow to build `polkadot`/`polkadot-parachain` rc binaries and deb package (#5963) [ci] Remove short-benchmarks from Gitlab (#5988) Disable flaky tests reported in 5972/5973/5974 (#5976) Bump some dependencies (#5886) bump zombienet version and set request for k8s (#5968) [omni-bencher] Make all runtimes work (#5872) Omni-Node renamings (#5915) ...
This bumps
ethbloom
,ethereum-types
,primitive-types
andrlp
to their latest version.Fixes: #5870