[pallet-revive] fix xcm tests #5684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgherveou
added
R0-silent
ggwpez
approved these changes
Sep 12, 2024
xermicus
approved these changes
Sep 12, 2024
athei
approved these changes
Sep 12, 2024
| @@ -24,6 +24,7 @@ extern crate alloc; | |||
| pub fn compile_module(fixture_name: &str) -> anyhow::Result<(Vec<u8>, sp_core::H256)> { | |||
| let out_dir: std::path::PathBuf = env!("OUT_DIR").into(); | |||
| let fixture_path = out_dir.join(format!("{fixture_name}.polkavm")); | |||
| log::debug!("Loading fixture from {fixture_path:?}"); | |||
There was a problem hiding this comment.
oups left over , but I guess it's handy when you want to grab the path of a fixture ¯_(ツ)_/¯
| @@ -1790,17 +1790,20 @@ pub mod env { | |||
| &mut self, | |||
| memory: &mut M, | |||
| dest_ptr: u32, | |||
| dest_len: u32, | |||
There was a problem hiding this comment.
It's just so annoying that we don't have a FixedEncodedLen trait. But we probably can get rid of SCALE for everything except XCM.
There was a problem hiding this comment.
Yeah I was thinking the same, this can probably be added to parity-scale-codec later on to make it a bit safer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5683