-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pallet-revive] Add balance_of syscyall for fetching foreign balances #5675
Conversation
Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
bot bench substrate-pallet --pallet=pallet_revive |
@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318186 was started for your command Comment |
…=dev --target_dir=substrate --pallet=pallet_revive
@xermicus Command |
bot bench substrate-pallet --pallet=pallet_revive --features=riscv |
@xermicus unknown option '--features=riscv' |
bot bench help |
@xermicus Unknown subcommand of "bench". Refer to help docs and/or source code. |
bot bench substrate-pallet --pallet=pallet_revive -- --features=riscv |
@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7319583 was started for your command Comment |
@xermicus Command |
Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: xermicus <[email protected]>
bot bench substrate-pallet --pallet=pallet_revive |
@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7322691 was started for your command Comment |
@xermicus Command |
This reverts commit f4329d0.
15b2ad0
to
5efb99d
Compare
Signed-off-by: Cyrill Leutwiler <[email protected]>
bot bench substrate-pallet --pallet=pallet_revive |
@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7335312 was started for your command Comment |
@xermicus Command |
5405448
to
46bfd29
Compare
bot bench substrate-pallet --pallet=pallet_revive |
@xermicus https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7335781 was started for your command Comment |
@xermicus Command |
48da22f
to
5629d88
Compare
Signed-off-by: Cyrill Leutwiler <[email protected]>
5629d88
to
9ca0ec0
Compare
This adds an API method
balance_of
, corresponding to the BALANCE EVM opcode.In
Ext
,balance
andbalance_of
are internally routed through the same newaccount_balance
method:balance
is technically the same asbalance_of
with the caller address. This avoids duplicating all the tests and avoids a small inefficiency (in theory,balance
directly callbalance_of
however this introduces a round trip of converting the target address to a H160 and back).