Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Update CI image with rust 1.81.0 and 2024-09-11 #5676

Merged
merged 102 commits into from
Sep 26, 2024
Merged

[ci] Update CI image with rust 1.81.0 and 2024-09-11 #5676

merged 102 commits into from
Sep 26, 2024

Conversation

alvicsam
Copy link
Contributor

@alvicsam alvicsam commented Sep 11, 2024 •
edited
Loading

@alvicsam alvicsam requested review from a team as code owners September 11, 2024 10:27
@alvicsam alvicsam added the R0-silent Changes should not be mentioned in any release notes label Sep 11, 2024
@alvicsam
Copy link
Contributor Author

/cmd help

@github-actions GitHub Actions
Copy link

Command "help" has started 🚀 See logs here

@github-actions GitHub Actions
Copy link

Command "help" has failed ❌! See logs here

@alvicsam
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Sep 11, 2024 •
edited
Loading

@alvicsam https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318086 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-f635b668-ec61-4fba-8c53-6d0873da4411 to cancel this command or bot cancel to cancel all commands in this pull request.

@alvicsam
Copy link
Contributor Author

bot help

@command-bot
Copy link

command-bot bot commented Sep 11, 2024

@alvicsam Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318086 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318086/artifacts/download.

@command-bot
Copy link

command-bot bot commented Sep 11, 2024

Here's a link to docs

@alvicsam
Copy link
Contributor Author

bot -v CMD_IMAGE=docker.io/paritytech/ci-unified:bullseye-1.81.0-2024-09-11-v202409111034 fmt

@command-bot
Copy link

command-bot bot commented Sep 11, 2024 •
edited
Loading

@alvicsam https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318088 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-69c20856-38ce-4cb3-90f3-359d2f53dde3 to cancel this command or bot cancel to cancel all commands in this pull request.

@paritytech-ci paritytech-ci requested review from a team and koute as code owners September 11, 2024 10:36
@command-bot
Copy link

command-bot bot commented Sep 11, 2024

@alvicsam Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318088 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318088/artifacts/download.

@paritytech-review-bot paritytech-review-bot bot requested a review from a team September 11, 2024 10:37
@alvicsam
Copy link
Contributor Author

bot update-ui latest --rust_version=1.81

@command-bot
Copy link

command-bot bot commented Sep 11, 2024 •
edited
Loading

@alvicsam https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318182 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" --rust_version=1.81. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-ab4bc0bc-095e-4f2b-8ae0-24b6a3628629 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Sep 11, 2024

@alvicsam Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" --rust_version=1.81 has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318182 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7318182/artifacts/download.

@alvicsam
Copy link
Contributor Author

@ggwpez could you please help with the CI errors (tests, clippy)?

@ggwpez
Copy link
Member

ggwpez commented Sep 11, 2024

@gui1117 i applied your fix here, just FYI

@ggwpez
Clippy
f676227 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Copy link
Member

ggwpez commented Sep 23, 2024

Looking for one review from @bkontur, @serban300 or @acatangiu and then we can merge.

@tmpolaczyk tmpolaczyk mentioned this pull request Sep 24, 2024
Merged
@nanocryk nanocryk mentioned this pull request Sep 25, 2024
Merged
@ggwpez ggwpez mentioned this pull request Sep 25, 2024
Merged
@Wolfenheimm Wolfenheimm mentioned this pull request Sep 26, 2024
Open
4 tasks
Wolfenheimm added a commit to Wolfenheimm/polkadot-sdk that referenced this pull request Sep 26, 2024
@Wolfenheimm
Update rust-toolchain.toml
d49ff1e 
Changed the rust version to reflect  [paritytech#5676](paritytech#5676)
@ggwpez ggwpez added this pull request to the merge queue Sep 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2024
@alvicsam alvicsam mentioned this pull request Sep 26, 2024
Merged
@ggwpez ggwpez added this pull request to the merge queue Sep 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 26, 2024
@ggwpez
fix prdoc
7b74876 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez
Merge branch 'master' into as-upd-rust
e14a466
@ggwpez
fmt
d24475d 
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez added this pull request to the merge queue Sep 26, 2024
Merged via the queue into master with commit 6c3219e Sep 26, 2024
218 of 219 checks passed
@ggwpez ggwpez deleted the as-upd-rust branch September 26, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgherveou pgherveou pgherveou left review comments

@nazar-pc nazar-pc nazar-pc left review comments

@ggwpez ggwpez ggwpez left review comments

@bkchr bkchr bkchr approved these changes

@serban300 serban300 serban300 approved these changes

@acatangiu acatangiu acatangiu approved these changes

@koute koute Awaiting requested review from koute koute is a code owner

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@alvicsam @ggwpez @nazar-pc @bkchr @athei @pgherveou @serban300 @acatangiu @mordamax @gui1117