-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
primitives: replace primitive Withdrawals
with alloy
#12119
Conversation
@joshieDo Seems like something is strange (maybe I missed something) but locally when I try to write the vectors for compac-codec tests it seems I've the right ones (reth-codecs Withdrawals) but on the CI here it seems this is not working the same way (generating with the old reth-primitives Withdrawals), maybe due to #11994 or maybe I did something wrong here :) |
Oh because the type name (or path) changed, therefore it doesn't exist on I'll create a PR to handle that |
@joshieDo nice thanks |
Yes I believe it was closed by accident |
@shekhirin No problem :) just rebased |
Co-authored-by: joshieDo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, ty
one more type unified
Should close #11798