Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primitives: replace primitive Withdrawals with alloy #12119

Merged
merged 19 commits into from
Nov 9, 2024

Conversation

tcoratger
Copy link
Contributor

Should close #11798

@tcoratger
Copy link
Contributor Author

@joshieDo Seems like something is strange (maybe I missed something) but locally when I try to write the vectors for compac-codec tests it seems I've the right ones (reth-codecs Withdrawals) but on the CI here it seems this is not working the same way (generating with the old reth-primitives Withdrawals), maybe due to #11994 or maybe I did something wrong here :)

image

@joshieDo
Copy link
Collaborator

Oh because the type name (or path) changed, therefore it doesn't exist on main.

I'll create a PR to handle that

@tcoratger
Copy link
Contributor Author

Oh because the type name (or path) changed, therefore it doesn't exist on main.

I'll create a PR to handle that

@joshieDo nice thanks

@tcoratger
Copy link
Contributor Author

tcoratger commented Oct 28, 2024

Hey @mattsse is there a reason for this to be closed :)? we should just rebase after #12125 is merged no? I think it closed automatically after the merge of the other one :)

@shekhirin
Copy link
Collaborator

Yes I believe it was closed by accident

@shekhirin shekhirin reopened this Oct 28, 2024
@tcoratger
Copy link
Contributor Author

Yes I believe it was closed by accident

@shekhirin No problem :) just rebased

@tcoratger
Copy link
Contributor Author

hey @mattsse @joshieDo anything to add here or can we merge?

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty
one more type unified

@tcoratger
Copy link
Contributor Author

lgtm, ty one more type unified

@mattsse Yes that's nice! happy to see the progress. Next one could be Receipts here #12162

Let me know if this is ready to be merged, will solve conflicts there if needed

@mattsse mattsse added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to invalid changes in the merge commit Nov 8, 2024
@mattsse mattsse added this pull request to the merge queue Nov 9, 2024
Merged via the queue into paradigmxyz:main with commit d2f494b Nov 9, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

primitives: use alloy Withdrawals
4 participants