Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primitives: use alloy Withdrawals #11798

Closed
Tracked by #12576
tcoratger opened this issue Oct 16, 2024 · 4 comments · Fixed by #12119
Closed
Tracked by #12576

primitives: use alloy Withdrawals #11798

tcoratger opened this issue Oct 16, 2024 · 4 comments · Fixed by #12119
Labels
C-enhancement New feature or request S-blocked This cannot more forward until something else changes

Comments

@tcoratger
Copy link
Contributor

Describe the feature

At the moment, we have defined a Withdrawals structure inside the primitive-traits crate:

pub struct Withdrawals(Vec<Withdrawal>);

After the merge of alloy-rs/alloy#1462, this definition could be removed in reth and replaced by a simple import of the equivalent alloy type.

Additional context

No response

@tcoratger tcoratger added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Oct 16, 2024
@Gerson2102
Copy link
Contributor

Seems not too hard, can I work on it? What do you think? @tcoratger

@tcoratger
Copy link
Contributor Author

Seems not too hard, can I work on it? What do you think? @tcoratger

I think it could be a good first issue wdyt @mattsse? Maybe we can provide some guidance if needed :) Happy to help. This is blocked by alloy-rs/alloy#1462 at the moment

@Rjected Rjected added S-blocked This cannot more forward until something else changes and removed S-needs-triage This issue needs to be labelled labels Oct 16, 2024
@tcoratger
Copy link
Contributor Author

Should be unlocked by new alloy release alloy-rs/alloy@3117f76

@Gerson2102
Copy link
Contributor

Ready to work on this one if it is possible @mattsse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request S-blocked This cannot more forward until something else changes
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants