feat(eip4895): implement Withdrawals
#1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
tcoratger
force-pushed
the
Withdrawals
branch
from
7867a13
to
6022650
Compare
DaniPopes
changed the title
WithdrawalsWithdrawals
|
@mattsse nice bump should be ready to review/merge |
mattsse
reviewed
Oct 16, 2024
|
@mattsse nice bump here, anything missing? |
mattsse
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to centralize withdrawal definitions in alloy and remove this implementation https://github.com/paradigmxyz/reth/blob/661b260f6172c047e8530e2331b2c84141e03c2b/crates/primitives-traits/src/withdrawal.rs#L35 from reth, we need to properly have the
Withdrawalsstruct in alloy.We can improve it as needed in the future.