eip4895: make Vec<Withdrawal> pub in Withdrawals
#1590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
emhane
as code owners
onbjerg
reviewed
Oct 30, 2024
| @@ -57,32 +57,32 @@ impl Withdrawal { | |||
| )] | |||
| #[cfg_attr(any(test, feature = "arbitrary"), derive(arbitrary::Arbitrary))] | |||
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | |||
| pub struct Withdrawals(Vec<Withdrawal>); | |||
| pub struct Withdrawals(pub Vec<Withdrawal>); | |||
There was a problem hiding this comment.
I personally think this makes the API a bit confused, either we make this pub and remove the iter/into_inner or we continue as the API is today and add as_ref. there's no reason to have eg iter if this is pub as you can now just do withdrawals.0.iter()
There was a problem hiding this comment.
I agree and I think that we can remove iter/into_inner, will make everything more generic with less functions. Let me know what you think and I can adapt
There was a problem hiding this comment.
actually we already have AsRef for this (through derive), so I believe we can use it in reth and avoid any changes here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related paradigmxyz/reth#12119 (comment)