-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate getting the name from MultiIndex.levels #29032
Comments
xref https://issues.apache.org/jira/browse/ARROW-6922 / pandas-dev#27242 (comment) / pandas-dev#29032 No docs yet, since it isn't clear how this will eventually sort out. But we at least want to preserve this behavior for 1.0
FWIW, I'm probably OK with not deprecating In [6]: idx = pd.MultiIndex.from_product([['a'], [1, 2]], names=['a', 'b'])
In [7]: idx.levels[0].name = 'c'
In [8]: idx
Out[8]:
MultiIndex([('a', 1),
('a', 2)],
names=['a', 'b']) |
* API: Restore getting name from MultiIndex level xref https://issues.apache.org/jira/browse/ARROW-6922 / #27242 (comment) / #29032 No docs yet, since it isn't clear how this will eventually sort out. But we at least want to preserve this behavior for 1.0 * fixups
So, where are we wrt to renaming to categories? IMO the name |
I think deprecating |
I am personally also not fully convinced that renaming |
* API: Restore getting name from MultiIndex level xref https://issues.apache.org/jira/browse/ARROW-6922 / pandas-dev#27242 (comment) / pandas-dev#29032 No docs yet, since it isn't clear how this will eventually sort out. But we at least want to preserve this behavior for 1.0 * fixups
Any more thoughts here? I'm probably OK with the behavior on master
If we go with that, we'll need to thoroughly document this behavior. Regardless of what we do, the release notes in https://dev.pandas.io/docs/whatsnew/v1.0.0.html#multiindex-levels-do-not-hold-level-names-any-longer will need to be updated. |
would be great if we could show a warning for 2 (but still do nothing) |
Pushed #29572 for the 1.0 docs. I don't think warning for setting |
* API: Restore getting name from MultiIndex level xref https://issues.apache.org/jira/browse/ARROW-6922 / pandas-dev#27242 (comment) / pandas-dev#29032 No docs yet, since it isn't clear how this will eventually sort out. But we at least want to preserve this behavior for 1.0 * fixups
* API: Restore getting name from MultiIndex level xref https://issues.apache.org/jira/browse/ARROW-6922 / pandas-dev#27242 (comment) / pandas-dev#29032 No docs yet, since it isn't clear how this will eventually sort out. But we at least want to preserve this behavior for 1.0 * fixups
* API: Restore getting name from MultiIndex level xref https://issues.apache.org/jira/browse/ARROW-6922 / pandas-dev#27242 (comment) / pandas-dev#29032 No docs yet, since it isn't clear how this will eventually sort out. But we at least want to preserve this behavior for 1.0 * fixups
Follow up to #27242.
#27242 (comment)
The text was updated successfully, but these errors were encountered: