Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update MultiIndex.names whatsnew #29572

Merged
merged 5 commits into from
Nov 17, 2019

Conversation

TomAugspurger
Copy link
Contributor

xref #29032

Doesn't quite close it, in case someone has time to implement a deprecation. But that doesn't seem likely for 1.0

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. tiny sp comment.

@@ -130,34 +130,39 @@ Backwards incompatible API changes

.. _whatsnew_1000.api_breaking.MultiIndex._names:

``MultiIndex.levels`` do not hold level names any longer
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Aviod using names from ``MultiIndex.levels``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid

@WillAyd WillAyd merged commit ef10c89 into pandas-dev:master Nov 17, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 17, 2019

Thanks @TomAugspurger

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants