-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Restore getting name from MultiIndex level #29061
Conversation
xref https://issues.apache.org/jira/browse/ARROW-6922 / pandas-dev#27242 (comment) / pandas-dev#29032 No docs yet, since it isn't clear how this will eventually sort out. But we at least want to preserve this behavior for 1.0
what is exactly the error from pyarrow? |
I'm working on the implementation discussed in #27242, including new to be deprecated levels with names. Won't that fix this issue? |
As I mentioned in the other issue, IMO we should first properly discuss if we actually want to deprecate
pyarrow is using the name of a level, and this is now no longer preserved. |
Let's merge this, and discuss future plans in #29032? This at least gets CI passing for downstream projects. |
sgtm. |
do we have sufficient tests for downstream though (can be added later in test_downstream.py) |
I am not sure additional tests are needed. We have tests for it in out own tests. We just broke purposefully our API (and change our own tests to reflect that), so it is to be expected that behaviour that relies on accessing the level names like this will be broken. |
@TomAugspurger thanks for the quick PR! @topper-123 As mentioned above, IMO we should still first have a discussion about a deprecation of |
The discussion about the future of .levels can happen in #29032. |
* API: Restore getting name from MultiIndex level xref https://issues.apache.org/jira/browse/ARROW-6922 / pandas-dev#27242 (comment) / pandas-dev#29032 No docs yet, since it isn't clear how this will eventually sort out. But we at least want to preserve this behavior for 1.0 * fixups
* API: Restore getting name from MultiIndex level xref https://issues.apache.org/jira/browse/ARROW-6922 / pandas-dev#27242 (comment) / pandas-dev#29032 No docs yet, since it isn't clear how this will eventually sort out. But we at least want to preserve this behavior for 1.0 * fixups
* API: Restore getting name from MultiIndex level xref https://issues.apache.org/jira/browse/ARROW-6922 / pandas-dev#27242 (comment) / pandas-dev#29032 No docs yet, since it isn't clear how this will eventually sort out. But we at least want to preserve this behavior for 1.0 * fixups
* API: Restore getting name from MultiIndex level xref https://issues.apache.org/jira/browse/ARROW-6922 / pandas-dev#27242 (comment) / pandas-dev#29032 No docs yet, since it isn't clear how this will eventually sort out. But we at least want to preserve this behavior for 1.0 * fixups
xref https://issues.apache.org/jira/browse/ARROW-6922 /
#27242 (comment)
/ #29032
No docs yet, since it isn't clear how this will eventually sort out. But
we at least want to preserve this behavior for 1.0
cc @jorisvandenbossche @topper-123