Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Restore getting name from MultiIndex level #29061

Merged
merged 2 commits into from
Oct 18, 2019

Conversation

TomAugspurger
Copy link
Contributor

xref https://issues.apache.org/jira/browse/ARROW-6922 /
#27242 (comment)
/ #29032

No docs yet, since it isn't clear how this will eventually sort out. But
we at least want to preserve this behavior for 1.0

cc @jorisvandenbossche @topper-123

xref https://issues.apache.org/jira/browse/ARROW-6922 /
pandas-dev#27242 (comment)
/ pandas-dev#29032

No docs yet, since it isn't clear how this will eventually sort out. But
we at least want to preserve this behavior for 1.0
@TomAugspurger TomAugspurger added this to the 1.0 milestone Oct 17, 2019
@jreback
Copy link
Contributor

jreback commented Oct 17, 2019

what is exactly the error from pyarrow?

@topper-123
Copy link
Contributor

I'm working on the implementation discussed in #27242, including new to be deprecated levels with names. Won't that fix this issue?

@jorisvandenbossche
Copy link
Member

I'm working on the implementation discussed in #27242, including new to be deprecated levels with names. Won't that fix this issue?

As I mentioned in the other issue, IMO we should first properly discuss if we actually want to deprecate .levels
And in general, I would prefer to not have master in a "broken" state (meaning that we removed something that will only be temporary). For projects trying to be good citizens and testing against pandas master that is a bit annoying.

what is exactly the error from pyarrow?

pyarrow is using the name of a level, and this is now no longer preserved.

@TomAugspurger
Copy link
Contributor Author

Let's merge this, and discuss future plans in #29032? This at least gets CI passing for downstream projects.

@jreback jreback merged commit b0f33b3 into pandas-dev:master Oct 18, 2019
@jreback
Copy link
Contributor

jreback commented Oct 18, 2019

sgtm.

@jreback
Copy link
Contributor

jreback commented Oct 18, 2019

do we have sufficient tests for downstream though (can be added later in test_downstream.py)

@jorisvandenbossche
Copy link
Member

do we have sufficient tests for downstream though (can be added later in test_downstream.py)

I am not sure additional tests are needed. We have tests for it in out own tests. We just broke purposefully our API (and change our own tests to reflect that), so it is to be expected that behaviour that relies on accessing the level names like this will be broken.

@jorisvandenbossche
Copy link
Member

@TomAugspurger thanks for the quick PR!

@topper-123 As mentioned above, IMO we should still first have a discussion about a deprecation of .levels. Do you want to open a dedicated issue for that? (or is there already an issue to discuss that?)

@TomAugspurger TomAugspurger deleted the restore-level-name branch October 18, 2019 21:57
@TomAugspurger
Copy link
Contributor Author

The discussion about the future of .levels can happen in #29032.

HawkinsBA pushed a commit to HawkinsBA/pandas that referenced this pull request Oct 29, 2019
* API: Restore getting name from MultiIndex level

xref https://issues.apache.org/jira/browse/ARROW-6922 /
pandas-dev#27242 (comment)
/ pandas-dev#29032

No docs yet, since it isn't clear how this will eventually sort out. But
we at least want to preserve this behavior for 1.0

* fixups
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
* API: Restore getting name from MultiIndex level

xref https://issues.apache.org/jira/browse/ARROW-6922 /
pandas-dev#27242 (comment)
/ pandas-dev#29032

No docs yet, since it isn't clear how this will eventually sort out. But
we at least want to preserve this behavior for 1.0

* fixups
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
* API: Restore getting name from MultiIndex level

xref https://issues.apache.org/jira/browse/ARROW-6922 /
pandas-dev#27242 (comment)
/ pandas-dev#29032

No docs yet, since it isn't clear how this will eventually sort out. But
we at least want to preserve this behavior for 1.0

* fixups
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
* API: Restore getting name from MultiIndex level

xref https://issues.apache.org/jira/browse/ARROW-6922 /
pandas-dev#27242 (comment)
/ pandas-dev#29032

No docs yet, since it isn't clear how this will eventually sort out. But
we at least want to preserve this behavior for 1.0

* fixups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants