Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate off JUnit 4 vintage #2495

Closed
wants to merge 63 commits into from
Closed

Migrate off JUnit 4 vintage #2495

wants to merge 63 commits into from

Conversation

schlosna
Copy link
Contributor

Before this PR

JUnit 5 excavator #2485 is blocked due to incompatibilities with JUnit 4 vintage usage.

After this PR

==COMMIT_MSG==
Migrate off JUnit 4 vintage
==COMMIT_MSG==

Possible downsides?

@schlosna schlosna requested a review from carterkozak November 11, 2022 20:29
@schlosna
Copy link
Contributor Author

Need to confirm same 2079 tests as on develop.

@schlosna
Copy link
Contributor Author

There are 2087 tests on this branch's check build task

@schlosna schlosna marked this pull request as ready for review November 11, 2022 20:49
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/junit5 branch 2 times, most recently from dd729a5 to d7da33c Compare December 15, 2022 10:15
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/junit5 branch 3 times, most recently from 6d88096 to e35887e Compare January 10, 2023 17:44
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/junit5 branch 2 times, most recently from f6e2311 to 74b7cd1 Compare January 17, 2023 01:43
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/junit5 branch 3 times, most recently from b703578 to dbeb38e Compare January 31, 2023 01:55
@svc-excavator-bot svc-excavator-bot force-pushed the roomba/junit5 branch 2 times, most recently from c44ec1d to dcaaf8c Compare March 9, 2023 22:22
svc-excavator-bot and others added 10 commits April 17, 2023 23:11
@schlosna schlosna mentioned this pull request Apr 21, 2023
Closed
svc-excavator-bot and others added 11 commits April 21, 2023 17:26
@svc-excavator-bot
Excavator: Upgrade dependencies (#2606)
612bc16
@svc-excavator-bot
Excavator: Upgrade dependencies (#2607)
d4ece22
@carterkozak
SslSocketFactoriesTests checks if Conscrypt is supported (#2610)
114c425 
SslSocketFactoriesTests checks if Conscrypt is supported
@carterkozak
SslSocketFactories avoids duplicate effort creating TLS components (#…
51d201f 
…2609)

SslSocketFactories avoids duplicate effort creating TLS components
@svc-autorelease
Autorelease 7.54.0
f1e0ddb 
[skip ci]
@jpcorreia99
Client configuration build accepts TrustContextFactory (#2611)
9d1418f 
Overload client config creation method to allow a TrustContextFactory to be passed as well.
@svc-autorelease
Autorelease 7.55.0
0d6b79f 
[skip ci]
@svc-excavator-bot
Excavator: Upgrade dependencies (#2612)
7ce426c
@svc-excavator-bot
Excavator: Upgrade dependencies (#2613)
179b3ef
@svc-excavator-bot
Excavator: Update conjure plugins and dependencies (#2614)
6538261
@svc-excavator-bot
Excavator: Format Java files (#2615)
936ba36
@schlosna schlosna mentioned this pull request Apr 28, 2023
Merged
@schlosna schlosna closed this Apr 28, 2023
@schlosna schlosna deleted the ds/junit5 branch April 28, 2023 16:51
@schlosna schlosna restored the ds/junit5 branch April 28, 2023 16:51
@bulldozer-bot bulldozer-bot bot deleted the ds/junit5 branch April 28, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterkozak carterkozak Awaiting requested review from carterkozak

Assignees
No one assigned
Labels
merge when ready no changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@schlosna @svc-excavator-bot @carterkozak @svc-autorelease @jpcorreia99