Migrate to junit5 #2616
Merged
Migrate to junit5 #2616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
CJR was using JUnit 4 and excavator #2485 was stuck trying to migrate to JUnit 5
2093 tests complete on
developcheck taskAfter this PR
Cherry-picked JUnit 5 excavator from #2485 and updated tests still using
@Ruleto still use JUnit 4 vintage. This is a smaller change than #2495 that completely eradicates JUnit 4, so targeting this sooner to unblock excavator.2093 tests complete on this branch's
checktask==COMMIT_MSG==
Migrate to junit5
==COMMIT_MSG==
Closes #2605 & #2485
Possible downsides?