Client configuration build accepts TrustContextFactory #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
jpcorreia99
changed the title
carterkozak
reviewed
Apr 25, 2023
keystores/src/main/java/com/palantir/conjure/java/config/ssl/TrustContextFactory.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
Apr 25, 2023
keystores/src/main/java/com/palantir/conjure/java/config/ssl/SslSocketFactories.java
Outdated
Show resolved
Hide resolved
carterkozak
approved these changes
Apr 25, 2023
|
Released 7.55.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if consumers of this library want to build a client configuration but also be able to provide their own SSLSocketFactory and TrustManagers, the only option they have to do so, is via this call which does not allow the consumers to provide any extra configuration.
This PR overloads the
ofmethod to allow for aTrustContextFactoryto be passed alongside the normalServiceConfiguration, letting the caller have control both over SSL related classes and configuration.Also overloads the
createTrustContextmethods to allow a securityProviderclass to be passed.After this PR
==COMMIT_MSG==
Overload client config creation method to allow a TrustContextFactory to be passed as well.
==COMMIT_MSG==
Possible downsides?
The factory may get abused and provide SSL related classes that do not exactly match the security settings in the provided config.