Fix stats summary table time of year bugs #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rod-glover
force-pushed
the
stats-summary-time-bugs
branch
from
08bbad8 to
0305b53
Compare
corviday
approved these changes
Dec 7, 2018
| // This mixin is no longer relevant, since it is only used in the deprecated | ||
| // component MotiDataController. Dependence on it has been removed from all other | ||
| // data controllers. | ||
|
|
There was a problem hiding this comment.
Yay! Finally escaped the clutches of the mixin!
| function displayError(error, displayMethod) { | ||
| // Used to display any error (via `displayMethod`) generated in the | ||
| // process of showing a graph or table, so it handles networking | ||
| export function errorMessage(error) { |
There was a problem hiding this comment.
These changes seem familiar; does this branch need to be rebased?
rod-glover
force-pushed
the
stats-summary-time-bugs
branch
from
13a1521 to
91a21cb
Compare
|
Since rebase proceeded without manual merging, and follow-up change is trivial, I'm going to merge this without further review. It all works, still. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #215
Resolves #193
Resolves #176
This PR's main effect is
StatisticalSummaryTable. This component is extracted fromSingleDataControllerand significantly refactored to fix the time of year bug and conform to React 16+ lifecycle usage.SingleDataControllergets much simpler -- much of it is gone intoStatisticalSummaryTable. The diff is ugly though.Other effects are:
DualDataControllerto native class extension styleDataControllerMixinfromDualDataController