Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistical Summary allows user to select invalid Time of Year #215

Closed
rod-glover opened this issue Oct 17, 2018 · 3 comments · Fixed by #247
Closed

Statistical Summary allows user to select invalid Time of Year #215

rod-glover opened this issue Oct 17, 2018 · 3 comments · Fixed by #247
Assignees
Labels
bug Error in the application that needs to be fixed

Comments

@rod-glover
Copy link
Contributor

To reproduce:

  1. Home/Data > Single Variable
  2. Select Model = CanESM2; Emissions Scenario = historical, rcp85; Variable = altwsdiETCCDI
  3. In Statistical Summary table, Time of Year selector includes all values, but only Annual is valid. All other selections show an error message at the bottom, but keep displaying the annual value.

The ToY selector should only show valid selections. General UI rule: Don't offer a user an invalid course of action.

@corviday
Copy link
Contributor

corviday commented Oct 17, 2018

Related enough it should probably be handled in the same PR: sometimes the initialization process selects an invalid Time of Year too.

@corviday
Copy link
Contributor

Probably also the cause of this issue.

@rod-glover rod-glover self-assigned this Oct 18, 2018
@rod-glover rod-glover added the bug Error in the application that needs to be fixed label Oct 18, 2018
@rod-glover
Copy link
Contributor Author

@corviday suggests cause: Stats table needs an algorithm parallel to the one for graphs that matches datasets on time resolution. ToY selector needs to (be fed data that):

  1. Show all and only valid time resolutions.
  2. Select a valid default.

Stats table needs first to be refactored into its own component first, to give this logic a legitimate place to live.

Addressing this should fix all 3 of these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Error in the application that needs to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants