perf(linter/jsx-no-comment-textnodes): remove regex for checking comment patterns

[camchenry]

Improves performance of this rule by replacing Regex with simpler string methods. On the RadixUIAdoptionSection.jsx file alone, this improves performance by ~5%:

hyperfine --warmup 100 --shell=none --runs 3000 './oxlint-main -W jsx-no-comment-textnodes --silent ./RadixUIAdoptionSection.jsx' './oxlint-jsx-no-comment-textnodes-no-regex -W jsx-no-comment-textnodes --silent ./RadixUIAdoptionSection.jsx'
Benchmark 1: ./oxlint-main -W jsx-no-comment-textnodes --silent ./RadixUIAdoptionSection.jsx
  Time (mean ± σ):       4.4 ms ±   0.1 ms    [User: 1.7 ms, System: 1.9 ms]
  Range (min … max):     4.1 ms …   5.3 ms    3000 runs

Benchmark 2: ./oxlint-jsx-no-comment-textnodes-no-regex -W jsx-no-comment-textnodes --silent ./RadixUIAdoptionSection.jsx
  Time (mean ± σ):       4.2 ms ±   0.1 ms    [User: 1.5 ms, System: 1.8 ms]
  Range (min … max):     3.9 ms …   5.0 ms    3000 runs

Summary
  ./oxlint-jsx-no-comment-textnodes-no-regex -W jsx-no-comment-textnodes --silent ./RadixUIAdoptionSection.jsx ran
    1.06 ± 0.05 times faster than ./oxlint-main -W jsx-no-comment-textnodes --silent ./RadixUIAdoptionSection.jsx

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[camchenry]

• perf(linter/numeric-separators-style): replace regex with number parser #6546
• perf(linter/react): remove regex patterns in no-unknown-property #6536
• perf(linter/jsx-no-comment-textnodes): remove regex for checking comment patterns #6534 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camchenry and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #6534 will not alter performance

_{Comparing 10-13-perf_linter_jsx-no-comment-textnodes_remove_regex_for_checking_comment_patterns (62afaa9) with main (8d9a2da)}

Summary

✅ 30 untouched benchmarks

[camchenry]

@DonIsaac i think this is ready to be review. I was going to wait until we had the small file benchmark, but I think there's enough data to show this is most likely a perf win.

[camchenry]

Merge activity

• Oct 15, 12:09 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Oct 15, 12:09 AM EDT: A user added this pull request to the Graphite merge queue.
• Oct 15, 12:09 AM EDT: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason.
• Oct 15, 1:02 AM EDT: A user added this pull request to the Graphite merge queue.
• Oct 15, 1:07 AM EDT: A user merged this pull request with the Graphite merge queue.