Skip to content

Commit

Permalink
perf(linter): use CompactStr in no-console (#6399)
Browse files Browse the repository at this point in the history
  • Loading branch information
camchenry committed Oct 10, 2024
1 parent 384d5be commit 71dbdad
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions crates/oxc_linter/src/rules/eslint/no_console.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use oxc_ast::{ast::Expression, AstKind};
use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint;
use oxc_span::Span;
use oxc_span::{CompactStr, Span};

use crate::{context::LintContext, rule::Rule, AstNode};

Expand All @@ -21,7 +21,7 @@ pub struct NoConsoleConfig {
/// console.log('foo'); // will error
/// console.info('bar'); // will not error
/// ```
pub allow: Vec<String>,
pub allow: Vec<CompactStr>,
}

impl std::ops::Deref for NoConsole {
Expand Down Expand Up @@ -58,10 +58,7 @@ impl Rule for NoConsole {
.and_then(|v| v.get("allow"))
.and_then(serde_json::Value::as_array)
.map(|v| {
v.iter()
.filter_map(serde_json::Value::as_str)
.map(ToString::to_string)
.collect()
v.iter().filter_map(serde_json::Value::as_str).map(CompactStr::from).collect()
})
.unwrap_or_default(),
}))
Expand Down

0 comments on commit 71dbdad

Please sign in to comment.