fix(linter/no-control-regex): allow capture group references

[DonIsaac]

Closes #6525.

Allows \1, \2, etc. when referencing a capturing group.

Examples of now-allowed patterns:

// both of these have a capture group with an index of 1
const r = /([a-z]+)\1/; 
const r = /\1([a-z]+)/;

Examples of still-banned patterns:

/([a-z])\0/; //out of range: capture groups are 1-indexed
/([a-z])\2/; // there's only one capture group here

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[DonIsaac]

• fix(linter/no-control-regex): false negative for flags in template literals #6531
• fix(linter/no-control-regex): better diagnostic messages #6530
• fix(linter/no-control-regex): allow capture group references #6529 👈
• perf(regex): reduce string allocations in Display impls #6528
• refactor(linter/no-control-regex): remove duplicate code #6527
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #6529 will not alter performance

_{Comparing don/10-13-fix_linter/no-control-regex_allow_capture_group_references (6d5a9f2) with main (2c32dac)}

Summary

✅ 29 untouched benchmarks

[camchenry]

I'm surprised that these aren't picked up as indexed references instead of characters, I think this rule will be much more robust when we fix the regex to report char spans (#6141)

[graphite-app]

Merge activity

• Oct 13, 3:29 PM EDT: A user added this pull request to the Graphite merge queue.
• Oct 13, 3:45 PM EDT: A user merged this pull request with the Graphite merge queue.