Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkInProgress - Remove UIKit & cleanup files #324

Merged
merged 29 commits into from
Nov 22, 2018

Conversation

scramb
Copy link
Contributor

@scramb scramb commented Nov 16, 2018

Work-in-progress

Description

Added vuetify to files-app and adjusted core to use vuetify - no longer depending on UiKit.
Cleanup on store, and app-loading. While removing UiKit removed less-loader.

Related Issue

Motivation and Context

I tried to remove UiKit and replace it with vuetify, this solves the problem with themability, rtl-support and touch support. Would really love to get feedback on this while working on it.

How Has This Been Tested?

  • WIP not tested yet.

Screenshots (if appropriate):

2018-11-16-113221_1919x904_scrot
2018-11-22-111654_1906x901_scrot
2018-11-22-111631_1903x863_scrot

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Notification/Snackbar to queue all notifications
  • add files functions like createFolder
  • adjust File-Details.vue in apps/files
  • Side bar is not opening - let's chat on how to activate it ... see File actions API #149
  • new folder - can enter name but no action on [enter]
  • file filter not working

@scramb scramb self-assigned this Nov 16, 2018
@scramb scramb requested a review from DeepDiver1975 November 16, 2018 10:46
@tempelgogo
Copy link
Contributor

The vuetify Snackbar is unfortunately implemented as a component.
I've written a NotificationBar component wrapping up the vuetify Snackbar, reading a new notification queue from vuex store.
I do also provide a global vuex action to add a new Notification, analogous to the global $uikit.notification() method.

Some questions are open before i can release the code:

  • respecting the Material Design Guidelines, multiple Toast/Snackbar messages are not allowed.
    What is the intended behaviour, if multiple notifications are thrown ?
    • ignore the first, show last
    • ignore the last, show first
    • enqueue them, show them in sequence respecting their timeout
    • ignore the MD guidelines, rewrite CSS & allow multiple notifications ?
  • is a global reachable addNotification action ok; Or should i create some global "PhoenixUI" object, which we can expose for apps to interact with Phoenix Core ?

I personally prefer to enqueue them, and show them consecutively

@scramb
Copy link
Contributor Author

scramb commented Nov 16, 2018

@tempelgogo thanks for your feedback - i would prefer to show them consecutively aswell!

@DeepDiver1975
Copy link
Member

* respecting the Material Design Guidelines, multiple Toast/Snackbar messages are not allowed.

a good question for the ux workshop - please keep a note. For now we choose the less effort implementation.

Copy link
Member

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress ... minor changes requested ... will test in depth asap ....

apps/files/src/components/Files-App.vue Outdated Show resolved Hide resolved
apps/files/src/components/Files-App.vue Outdated Show resolved Hide resolved
src/components/Menu.vue Outdated Show resolved Hide resolved
src/components/Menu.vue Show resolved Hide resolved
@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Nov 19, 2018

  • Side bar is not opening - let's chat on how to activate it ... see File actions API #149
  • new folder - can enter name but no action on [enter]
  • file filter not working

@scramb
Copy link
Contributor Author

scramb commented Nov 19, 2018

* [ ]  Side bar is not opening - let's chat on how to activate it ... see #149

* [ ]  new folder - can enter name but no action on [enter]

* [ ]  file filter not working

added those to the To-Do's - i'm refcatoring while re-enabling existing functions and did not came through to put the filter function up again... pug took me a long time...
Sidebar is working for me i'll check on that asap same for folder create

@DeepDiver1975
Copy link
Member

pug took me a long time...

"Ceterum censeo Pugem esse delendam"

src/components/Menu.vue Outdated Show resolved Hide resolved
@tempelgogo tempelgogo changed the title WorkInProgress - Remove UIKit & cleaunup files WorkInProgress - Remove UIKit & cleanup files Nov 20, 2018
@tempelgogo tempelgogo mentioned this pull request Nov 22, 2018
@DeepDiver1975 DeepDiver1975 merged commit 3a32fb3 into master Nov 22, 2018
@DeepDiver1975 DeepDiver1975 deleted the feature/UiKit-remove branch November 22, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants