Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load anything from the Internet #228

Closed
PVince81 opened this issue Sep 18, 2018 · 6 comments · Fixed by #319
Closed

Don't load anything from the Internet #228

PVince81 opened this issue Sep 18, 2018 · 6 comments · Fixed by #319

Comments

@PVince81
Copy link
Contributor

We should bundle everything:

  • material icons, etc

Currently it connects to remote sites like google for downloading these.

@felixheidecke

@DeepDiver1975
Copy link
Member

scheduled for 0.2.0

@tempelgogo
Copy link
Contributor

tempelgogo commented Oct 17, 2018

  1. We could integrate the font files as static assets, with which either UiKit or Vuetify will seamless work.

  2. The optional alternative is to use a webpack extension like google-fonts-webpack-plugin, which automatically downloads the newest font version on each build & includes it into our bundle.
    I have used it before & it can be a nice way to integrate google fonts API into the automatic npm build process, but it's a little narrow-minded and may blow your pipeline if google font is not available.
    Because our pipeline server is always online, this should make no problems at all...

  3. If it's only about the material icon's, we could use the material-icons lib from npm, as prepared by @felixheidecke inside Material icons node dependency #127

@DeepDiver1975
Copy link
Member

@tempelgogo we need a solution which fits into theming as well. Themes can change icons ....

Which one of the proposed will work?

@tempelgogo
Copy link
Contributor

@tempelgogo we need a solution which fits into theming as well. Themes can change icons ....

Which one of the proposed will work?

All three proposals will include the font files & related stylesheets as static assets, while webpack will bundle them on phoenix build to a big, tree-shaked & compressed stylesheet.

The only option for theming, without rebundling the whole phoenix, is to use a separate theme-related stylesheet, which includes additional font files & extends the base bundle.

All three proposals can offer this, as they are only ways to manage the material icon package version.

The webpack plugin is able to manage all Webfonts offered from google, but this is only relevant if we are interested in some more google fonts.

In light of the fact that we only need material-icons and PR #127 is already prepared, I fully agree with @felixheidecke to use the npm-maintained version of the material icons.

@DeepDiver1975
Copy link
Member

Easiest and best to maintain approach is something webpack based I assume. @tempelgogo please choose and submit a pull request. THX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants