-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't load anything from the Internet #228
Comments
scheduled for 0.2.0 |
|
@tempelgogo we need a solution which fits into theming as well. Themes can change icons .... Which one of the proposed will work? |
All three proposals will include the font files & related stylesheets as static assets, while webpack will bundle them on phoenix build to a big, tree-shaked & compressed stylesheet. The only option for theming, without rebundling the whole phoenix, is to use a separate theme-related stylesheet, which includes additional font files & extends the base bundle. All three proposals can offer this, as they are only ways to manage the material icon package version. The webpack plugin is able to manage all Webfonts offered from google, but this is only relevant if we are interested in some more google fonts. In light of the fact that we only need material-icons and PR #127 is already prepared, I fully agree with @felixheidecke to use the npm-maintained version of the material icons. |
Easiest and best to maintain approach is something webpack based I assume. @tempelgogo please choose and submit a pull request. THX |
We should bundle everything:
Currently it connects to remote sites like google for downloading these.
@felixheidecke
The text was updated successfully, but these errors were encountered: