Material icons node dependency

[felixheidecke]

Remove link to fonts.googleapis.com in favor of material-icons node dependency

[felixheidecke]

@DeepDiver1975 can you help move the copy process to a nice method in the Makefile? … Pleeeeeeeease 😁

[PVince81]

you need to think in terms of "what is the target file" and "what are the source files" and "what is the command":

+    "compile-theme": "lessc src/themes/owncloud.less core/css/uikit.owncloud.css --relative-urls",
+    "compile-icons": "mkdir core/fonts && cp node_modules/material-icons/iconfont/MaterialIcons-Regular.* core/fonts/ && sass src/themes/icons.scss core/css/material-icons.css --no-source-map"

for compile-themes:

• target file: core/css/uikit.owncloud.css
• source file / dependencies: src/themes/owncloud.less
• process: `lessc $sourcefile $targetfile --relative-urls"

Makefile rule:

core/css/uikit.owncloud.css: src/themes/owncloud.less
    lessc $^ $@ --relative-urls

See https://www.gnu.org/software/make/manual/html_node/Automatic-Variables.html

for compile-icons part 1:

• target file: core/fonts/*
• source files: node_modules/material-icons/iconfont/MaterialIcons-Regular.*
• process: copy the source files over

Makefile rule:

core/fonts/: node_modules/material-icons/iconfont/MaterialIcons-Regular.*
    mkdir -p $@ && cp $^ $@

Where $@ is the target "core/fonts" and $^ is the stuff from node_modules

for compile-icons part 2:

• target file: core/css/material-icons.css
• source files: src/themes/icons.scss
• process: run sass

Makefile rule:

core/css/material-icons.css: src/themes/icons.scss
    sass $^ $@  --no-source-map

Then you need to make sure all these run when running regular make, so add more alias rules:

compile-theme: core/css/uikit.owncloud.css
compile-icons: core/fonts/ core/css/material-icons.css

then change the "all:" line and append "compile-theme compile-icons" so these rules run as well in the global make

[PVince81]

next, you need to split npm install in its own rule:

core-deps:
    npm install

then change core rule to just depend on the other rules

core: core-deps compile-icons compile-theme

[DeepDiver1975]

@felixheidecke conflicting

[PVince81]

Fixes #228

[PVince81]

see comments

[PVince81]

is the node in front of it required ? I thought one can just use directly whatever is in .bin (it might have a shebang)

[PVince81]

you can replace "core/css/material-icons.css" with $@ which is an alias for the target rule if you like

[PVince81]

if you use the placeholder % in the rule name, you need to also use it somewhere here in this command as $*.

[DeepDiver1975]

well - I basically want all MaterialIcons-Regular.* to be copied over

what would be the best rule to write this?

still asking myself if this is the right approach - can't webpack just grab that?

[PVince81]

yeah, I suspect webpack should be able to grab and even compile some stuff directly without needing extra Makefile rules.

[PVince81]

this might work only by chance

the "%" placeholder here will never have a value

I suggest just using "core/fonts" as dependency and have all the copying stuff done inside the "core/fonts" rule

[DeepDiver1975]

why not use https://www.npmjs.com/package/vue-material-design-icons ?

[DeepDiver1975]

why not use https://www.npmjs.com/package/vue-material-design-icons ?

has hint for webpack - https://gitlab.com/robcresswell/vue-material-design-icons#tips

[michaelstingl]

https://www.npmjs.com/package/vue-material-design-icons is MIT, but they're using https://github.com/Templarian/MaterialDesign , which is using SIL OPEN FONT LICENSE. Does this work for us?

[DeepDiver1975]

https://www.npmjs.com/package/vue-material-design-icons is MIT, but they're using https://github.com/Templarian/MaterialDesign , which is using SIL OPEN FONT LICENSE. Does this work for us?

@hodyroff

[felixheidecke]

why not use https://www.npmjs.com/package/vue-material-design-icons ?

The same reason why I don't fancy vueify right now. These would have to be compiled into each app instead of the theme.

[DeepDiver1975]

Can't we Deal with this by some intelligent bundling?