Tell groupMembership auto-complete test about the groups that exist #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
force-pushed
the
fix-acceptance-tests-groupMembership
branch
from
98c8544
to
3e84750
Compare
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
=========================================
Coverage 34.88% 34.88%
Complexity 1358 1358
=========================================
Files 32 32
Lines 3927 3927
=========================================
Hits 1370 1370
Misses 2557 2557Continue to review full report at Codecov.
|
|
@individual-it @DeepDiver1975 @PVince81 this fixes the acceptance test fails for the acceptance tests inside |
2 tasks
individual-it
approved these changes
Jun 13, 2018
|
Needs core changes to come in the overnight build. Then I will rerun CI here, and it should pass. |
|
All good in the LDAP testing world. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
user_ldapacceptance tests actually have a fixed list of users and groups that exist at the start of each scenario. But if a test scenario depends on understanding the particular mix of names that exist (e.g. auto-complete) then it needs to know about the relevant users and groups that exist.In core, I enhanced the auto-complete checks so they would complain if more entries are in the auto-complete list than expected. As a result, the test scenario here needs to know the group names that exist so it can decide what names should be in the auto-complete matches.