Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load users and groups fully into acceptance tests #250

Closed
phil-davis opened this issue Jun 14, 2018 · 4 comments
Closed

load users and groups fully into acceptance tests #250

phil-davis opened this issue Jun 14, 2018 · 4 comments

Comments

@phil-davis
Copy link
Contributor

Currently the users and groups used by the user_ldap acceptance tests are stored in ldap-users.ldif and that is loaded as the starting point for a test scenario.

The test scenario underlying code needs to be aware of what users and groups "magically exist" so that it can correctly know what to expect when sharing, examining autocomplete matches etc.

In PR #249 we explicitly pasted in the list of users and group in the test scenario setup steps.

Rather than do that, it will be cleaner if the code the loads in ldap-users.ldif also "tells" the test code about the users and groups it has "created".

@phil-davis
Copy link
Contributor Author

We need to discuss and sort out the dependency between the core test scenarios, that mention various users, groups and group membership, and the "fixed" set of users, groups and group membership that exists in user_ldap CI.

There is getting to be more non-obvious "magic use of particular users and groups" in the core test scenarios that is fragile and easily breaks user_ldap testing.

@phil-davis
Copy link
Contributor Author

More of this annoying stuff happened. See "fix" in owncloud/core#35746

It would be great to find a better way to organize this.

@phil-davis
Copy link
Contributor Author

And also owncloud/core#36480 owncloud/core#36481
It would be nice to have a way that users can be (optionally) existing/created at the start of a scenario without them being initialized (i.e. so that they do not already have the skeleton files existing)

@phil-davis
Copy link
Contributor Author

phil-davis commented Apr 13, 2020

We fixed this in the recent refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant