Acceptance test fails for user who is excluded from sharing tries to share a file with another user

[phil-davis]

These new core test scenarios are failing with LDAP:

--- Failed scenarios:

    /var/www/owncloud/server/tests/acceptance/features/apiShareManagement/createShare.feature:397
    /var/www/owncloud/server/tests/acceptance/features/apiShareManagement/createShare.feature:399
    /var/www/owncloud/server/tests/acceptance/features/apiShareManagement/createShare.feature:439
    /var/www/owncloud/server/tests/acceptance/features/apiShareManagement/createShare.feature:441

182 scenarios (178 passed, 4 failed)
2115 steps (2111 passed, 4 failed)

The user doing the sharing is in a group that is excluded from sharing, but still is able to share a file or folder.

Needs investigation.

[ownclouders]

GitMate.io thinks possibly related issues are #250 (load users and groups fully into acceptance tests), #348 (run acceptance tests with LDAPS), #350 (test "sharing with non unique group name" always fails the first time), #343 (Add api and webUI acceptance tests for modifying ldap user's attributes), and #364 (local user tries to access item shared by a LDAP user when LDAP server is offline).

[phil-davis]

Looks to be related to acceptance test code issues that also cause owncloud/core#33733
Could be fixed by core PR owncloud/core#35551

• see if user_ldap CI passes overnight, now that Refactor reShare.feature to use the 'shares file with, with permissions' steps core#35551 has been merged in core

[phil-davis]

@haribhandari07 please check if the tests mentioned here are still failing.
Hopefully tonight we will get a clean run of user_ldap CI.

[phil-davis]

Note: createShare.feature is in suite apiShareManagementBasic these days.
The relevant scenarios are now:

Scenario Outline: user who is excluded from sharing tries to share a file with another user
tests/acceptance/features/apiShareManagementBasic/createShare.feature:734
Scenario Outline: user who is excluded from sharing tries to share a file with a group
tests/acceptance/features/apiShareManagementBasic/createShare.feature:752
Scenario Outline: user who is excluded from sharing tries to share a folder with another user
tests/acceptance/features/apiShareManagementBasic/createShare.feature:773
Scenario Outline: user who is excluded from sharing tries to share a folder with a group
tests/acceptance/features/apiShareManagementBasic/createShare.feature:791

These are all passing locally with user_ldap for me.
And they pass in drone, e.g. https://drone.owncloud.com/owncloud/user_ldap/1767/883

[phil-davis]

The scenarios were unskipped by core PR owncloud/core#35559 owncloud/core#35551
All is good.