Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip autocompletion tests on LDAP - they rely on a complex user and g… #31750

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

phil-davis
Copy link
Contributor

…roup list

Signed-off-by: Phil Davis [email protected]

Description

Skip sharing auto-complete test scenarios on LDAP (older scenarios were already skipped).
Because they rely on having a more complex mix of users and groups than are set up in the LDAP tests at the moment.

Related Issue

#31747

Motivation and Context

New sharing autocomplete tests were added to better check the autocomplete matches under a mix of user ids, group ids and user display names. PR #31714 and backport #31729
Those tests require a suitable mix of users, display names and groups to exist. But user_ldap acceptance tests currently have a fixed list of users and groups.
So skip these scenarios on LDAP test runs.
We can add some more simple scenarios to the LDAP tests to check the autocomplete behavior there.

How Has This Been Tested?

CI knows

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix to acceptance tests

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 13, 2018

Codecov Report

Merging #31750 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #31750   +/-   ##
=========================================
  Coverage     63.16%   63.16%           
  Complexity    18445    18445           
=========================================
  Files          1158     1158           
  Lines         69288    69288           
  Branches       1261     1261           
=========================================
  Hits          43768    43768           
  Misses        25150    25150           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.47% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.39% <ø> (ø) 18445 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfff855...4159745. Read the comment docs.

@phil-davis phil-davis merged commit 9946a2b into master Jun 13, 2018
@phil-davis phil-davis deleted the skip-autocompletion-tests-on-LDAP branch June 13, 2018 14:28
@phil-davis
Copy link
Contributor Author

Backport stable10 #31750

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants