Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] temporarily disable parallel deployment tests #2955

Merged
merged 1 commit into from
Jan 12, 2022
Merged

[tests-only] temporarily disable parallel deployment tests #2955

merged 1 commit into from
Jan 12, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jan 12, 2022 •
edited by phil-davis
Loading

Description

Since REVA edge was introduced to oCIS yesterday, we can't use the owncloudSql storage driver for now, because it lacks an implementation.

Missing function:

https://github.com/cs3org/reva/blob/edge/pkg/storage/fs/owncloudsql/owncloudsql.go#L1953-L1956

Related Issue

#2950

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@wkloucek wkloucek force-pushed the temp-disable-parallel-deplyoment-tests branch from c87abdd to aa21e0e Compare January 12, 2022 15:43
@wkloucek wkloucek marked this pull request as ready for review January 12, 2022 15:48
@wkloucek wkloucek force-pushed the temp-disable-parallel-deplyoment-tests branch from aa21e0e to e4317e7 Compare January 12, 2022 15:49
@wkloucek wkloucek force-pushed the temp-disable-parallel-deplyoment-tests branch from e4317e7 to 5751b3d Compare January 12, 2022 15:49
@wkloucek wkloucek requested a review from butonic January 12, 2022 15:49
@owncloud owncloud deleted a comment from update-docs bot Jan 12, 2022
@phil-davis phil-davis changed the title temporarily disable parallel deployment tests [tests-only] temporarily disable parallel deployment tests Jan 12, 2022
phil-davis
phil-davis approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue somewhere that will remind us to enable it again some day?

@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@micbar micbar merged commit 060401a into master Jan 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the temp-disable-parallel-deplyoment-tests branch January 12, 2022 18:43
@phil-davis phil-davis mentioned this pull request Jan 13, 2022
Closed
2 tasks
@saw-jan saw-jan mentioned this pull request Jan 13, 2022
Closed
9 tasks
@wkloucek wkloucek mentioned this pull request Jan 17, 2022
Closed
@wkloucek
Copy link
Contributor Author

Tracking ticket for fix in REVA edge: #2972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@micbar micbar Awaiting requested review from micbar micbar is a code owner

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @phil-davis @micbar