Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Use built ocis server for parallel deployment tests #2951

Closed
wants to merge 2 commits into from

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Jan 12, 2022

Description

Do not use oCIS server from docker image but instead build the server when testing parallel deployment tests.
This was needed because when running tests using the latest docker image, the current changes will not be tested.
So even if the changes will actually break the tests, the parallel test pipelines will pass as we are testing the server from docker.
This is a false positive behavior. The changes will only be tested if they are merged (merging will create the new latest docker image with the latest changes).

This PR uses oCIS server that is built from the source which enables the changes to be tested early.

Related Issue

part of #2950

Motivation and Context

How Has This Been Tested?

  • test environment: CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Jan 12, 2022
@saw-jan saw-jan force-pushed the build-ocis-parallel branch 5 times, most recently from fa35245 to 4b9e0fb Compare January 12, 2022 09:52
@saw-jan saw-jan changed the title [tests-only] Build ocis server for parallel deployment tests [tests-only] Use built ocis server for parallel deployment tests Jan 12, 2022
@saw-jan saw-jan force-pushed the build-ocis-parallel branch 2 times, most recently from b59b1a7 to bd92b89 Compare January 12, 2022 10:15
@saw-jan
Copy link
Member Author

saw-jan commented Jan 12, 2022

parallel deployment tests are now running using an already built oCIS server and not from the docker image
https://drone.owncloud.com/owncloud/ocis/8690/4/14

@saw-jan saw-jan force-pushed the build-ocis-parallel branch 3 times, most recently from 7778138 to 09a4158 Compare January 12, 2022 10:51
@saw-jan saw-jan mentioned this pull request Jan 12, 2022
9 tasks
fix dependencies
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan
Copy link
Member Author

saw-jan commented Jan 13, 2022

Blocked currently. See #2955

@saw-jan saw-jan deleted the build-ocis-parallel branch March 11, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant