Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complete ownCloudSQL driver implementation on REVA edge #2972

Closed
wkloucek opened this issue Jan 17, 2022 · 3 comments
Closed

complete ownCloudSQL driver implementation on REVA edge #2972

wkloucek opened this issue Jan 17, 2022 · 3 comments
Assignees
@aduffeck
Labels
Storage:ownCloudSQL

Comments

@wkloucek
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The ownCloud SQL driver in REVA edge is missing the ListStorageSpaces implementation (https://github.com/cs3org/reva/blob/edge/pkg/storage/fs/owncloudsql/owncloudsql.go#L1953-L1956)

Describe the solution you'd like

We can use the ownCloud SQL driver in oCIS with REVA edge and therefore the interface must be implemented completely

Describe alternatives you've considered

Additional context
@wkloucek
Copy link
Contributor Author

@aduffeck can you please take care?

This was referenced Jan 17, 2022
Closed
Merged
@aduffeck
Copy link
Contributor

👍 I'm on it

@aduffeck aduffeck mentioned this issue Jan 25, 2022
Merged
@wkloucek
Copy link
Contributor Author

wkloucek commented Feb 1, 2022

implementation was merged in oCIS with #3052

@wkloucek wkloucek closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aduffeck aduffeck

Labels
Storage:ownCloudSQL
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aduffeck @wkloucek